Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scroller demo with fixed columns shouldn't have scrollbar in left pane... #1506

Closed
Stephen-Hazel opened this issue Jan 30, 2018 · 6 comments
Closed

Comments

@Stephen-Hazel
Copy link

In your demo here: https://mottie.github.io/tablesorter/docs/example-widget-scroller.html

when i use Firefox 52.2.0 there's a scrollbar for the left pane - the one with the fixed columns.
I'm guessing a width is a little messed up causing it to show when I'd expect it not to...

Is that fixable. If the columns are fixed, ideally no scroll bar there ever, right?

Thanks for a SUPER FANTASTICAL AMAZING table thingy that has made my boss SUPER HAPPY !!

@Stephen-Hazel
Copy link
Author

Actuallllllllly it looks like a problem due to the jui theme.
If i swap to the blue theme, no prob !

So less of a priority for me (none at all really).
It would be niiiice to use the prettier jui theme, but I can live with blue.

@Mottie
Copy link
Owner

Mottie commented Jan 30, 2018

Hi @Stephen-Hazel!

Oh, I guess I could add a jQuery UI theme selector on that page to test the other themes. Is there a particular theme you are using? Almost all of the alignment of the scroller is done with an injected stylesheet, so the styles can be overridden without including an !important flag.

@Stephen-Hazel
Copy link
Author

The problem is WITH the jui theme which the demo DOES use :)
I liked the look of the jui theme. But it exhibits the problem scrollbar.
(At least on my firefox 52.2.0 !!)
When I went back to the good ole blue theme, the scrollbar is gone like it should be.

I'm totally guessing that it's due to jQuery UI's borders and padding and junk (ARGH!)
JQuery UI -looks- great, but is very fiddly with the dang padding.

With jui theme in scroller demo ON FIREFOX 52.2.0,
You can see the scrollbar in bottom left on the pane that doesn't need side scrolling.
There's also a static rectangle (that's probably there to space the bottom properly).

With blue theme, everything is cool.

So now I'm just using the blue theme and there's no emergency.
But it wouuuuuld be nice to use that fancy jui theme some dayyy :)

Thanks for your AMAZIN COOOODE - I love eeeeet !!

@InhumanSoul
Copy link

I can confirm this bug in Firefox 52.6.0. The jQuery UI theme seems to be the only theme with this problem.

@Mottie
Copy link
Owner

Mottie commented Feb 5, 2018

I did a little tweaking of the scroller widget to account for jQuery UI spacing. Now it works in almost all jQuery UI themes. I'm not sure why there are 4 or 5 themes that still show the horizontal scroll bar.

@Mottie
Copy link
Owner

Mottie commented Mar 18, 2018

I'm guessing this issue has been resolved, so I'm going to close it. If you continue to have problems, please feel free to continue the discussion in this thread.

@Mottie Mottie closed this as completed Mar 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants