test: fail earlier when explicitly-named test dependencies are not found

MovingBlocks · May 19, 2022 · b5b42ae · b5b42ae
1 parent 1991556
commit b5b42ae
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/...src/main/java/org/terasology/engine/integrationenvironment/TestingStateHeadlessSetup.java b/...src/main/java/org/terasology/engine/integrationenvironment/TestingStateHeadlessSetup.java
@@ -28,6 +28,11 @@ public class TestingStateHeadlessSetup extends StateHeadlessSetup {
 
     private final Collection<String> dependencies;
     private final SimpleUri worldGeneratorUri;
+
+    {
+        strictModuleRequirements = true;
+    }
+
     public TestingStateHeadlessSetup(Collection<String> dependencies, String worldGeneratorUri) {
         this.dependencies = dependencies;
         this.worldGeneratorUri = new SimpleUri(worldGeneratorUri);

diff --git a/.../src/main/java/org/terasology/engine/core/subsystem/headless/mode/StateHeadlessSetup.java b/.../src/main/java/org/terasology/engine/core/subsystem/headless/mode/StateHeadlessSetup.java
@@ -1,4 +1,4 @@
-// Copyright 2021 The Terasology Foundation
+// Copyright 2022 The Terasology Foundation
 // SPDX-License-Identifier: Apache-2.0
 package org.terasology.engine.core.subsystem.headless.mode;
 
@@ -33,6 +33,8 @@ public class StateHeadlessSetup extends AbstractState {
 
     private static final Logger logger = LoggerFactory.getLogger(StateHeadlessSetup.class);
 
+    protected boolean strictModuleRequirements;
+
     public StateHeadlessSetup() {
     }
 
@@ -68,6 +70,8 @@ public GameManifest createGameManifest() {
             Module module = moduleManager.getRegistry().getLatestModuleVersion(moduleName);
             if (module != null) {
                 gameManifest.addModule(module.getId(), module.getVersion());
+            } else if (strictModuleRequirements) {
+                throw new RuntimeException("ModuleRegistry has no latest version for module " + moduleName);
             } else {
                 logger.warn("ModuleRegistry has no latest version for module {}", moduleName);
             }