-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: rename engine-module.txt to module.txt #4722
Conversation
engine/src/main/java/org/terasology/engine/core/module/ModuleManager.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the one thing you left out of this PR titled "rename engine-module.txt to module.txt" was renaming engine-module.txt
. π
Whoops π Should be done now |
Ah, now it runs with passing tests! I see versionInfo.properties is built with version information, and I believe the test cases will make sure that ModuleManager has a module of the appropriate name. I think that the only thing left to confirm is that you can actually run a game world in a real process with other (non-engine) modules present. Can't think of anything else in particular to look for beyond that. |
@jdrueckert do you want to merge this? |
need to test it properly (as keturn mentioned) first, but once that's done: yes. |
tests out fine in CoreGameplay, so I'll go ahead and merge this |
Resolves #4646
Tbh I have no idea, if this is what's expected to be done to resolve #4646 ...
I just thought I'd go for what I understood and use that as a basis for discussion π€·ββοΈ π