Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add disable_annotations options to disable stats report #162

Merged
merged 4 commits into from
Nov 27, 2024

Conversation

trim21
Copy link
Contributor

@trim21 trim21 commented Nov 27, 2024

close #161

@trim21 trim21 marked this pull request as ready for review November 27, 2024 03:14
@trim21
Copy link
Contributor Author

trim21 commented Nov 27, 2024

how do I test this?

looks fine in my fork

https://github.com/trim21/sccache-action/actions/runs/12043088159/job/33577898640

@trim21 trim21 changed the title add disable_annotations add disable_annotations options to disable stats report Nov 27, 2024
Xuanwo

This comment was marked as resolved.

Copy link
Collaborator

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @trim21, LGTM.

@Xuanwo Xuanwo requested a review from sylvestre November 27, 2024 09:10
- macos-latest
version:
- ""
- v0.4.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this version?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is copy from existing job, maybe we should keep a single job on ubuntu only?

@trim21 trim21 requested a review from sylvestre November 27, 2024 13:13
@sylvestre sylvestre merged commit 25839b6 into Mozilla-Actions:main Nov 27, 2024
8 checks passed
@sylvestre
Copy link
Collaborator

thanks!

@trim21
Copy link
Contributor Author

trim21 commented Nov 27, 2024

will there be a new version?

@trim21 trim21 deleted the disable_annotations branch November 27, 2024 13:19
@sylvestre
Copy link
Collaborator

of course :)

@trim21
Copy link
Contributor Author

trim21 commented Nov 27, 2024

may need to update version in https://github.com/Mozilla-Actions/sccache-action?tab=readme-ov-file#disable-stats-report or just remove this version

@sylvestre
Copy link
Collaborator

yeah, please remove the version, i missed it

@trim21
Copy link
Contributor Author

trim21 commented Nov 28, 2024

I forget this github actions can just use sha as ref, no need for a new version now :)

@sylvestre
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

options to disable post-run Annotations
3 participants