-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add disable_annotations
options to disable stats report
#162
Conversation
how do I test this? looks fine in my fork https://github.com/trim21/sccache-action/actions/runs/12043088159/job/33577898640 |
disable_annotations
options to disable stats report
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @trim21, LGTM.
.github/workflows/CI.yml
Outdated
- macos-latest | ||
version: | ||
- "" | ||
- v0.4.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is copy from existing job, maybe we should keep a single job on ubuntu only?
thanks! |
will there be a new version? |
of course :) |
may need to update version in https://github.com/Mozilla-Actions/sccache-action?tab=readme-ov-file#disable-stats-report or just remove this version |
yeah, please remove the version, i missed it |
I forget this github actions can just use sha as ref, no need for a new version now :) |
close #161