This repository has been archived by the owner on Mar 15, 2024. It is now read-only.
Add custom middleware and URL resolvers for ISO 3166 language prefixes. #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solarissmoke
force-pushed
the
feature/url-case
branch
from
cc75d3b
to
e684e1d
Compare
solarissmoke
force-pushed
the
feature/url-case
branch
from
e684e1d
to
257b9d6
Compare
ababic
approved these changes
Aug 19, 2019
|
Note that it seems to break the language negotiation (https://donate-wagtail-staging-pr-187.herokuapp.com/ gives me a 404 instead of redirecting to https://donate-wagtail-staging-pr-187.herokuapp.com/fr) |
|
Thanks @TheoChevalier - looks like I need to do a bit more work to get the language negotiation working - will sort this tomorrow. |
solarissmoke
force-pushed
the
feature/url-case
branch
4 times, most recently
from
db9ac2c
to
3c8eeca
Compare
|
@TheoChevalier would you be able to test this deployment again? It should now address your comment above about 404 with your language preference. |
|
Looks good with the latest, thanks @solarissmoke |
solarissmoke
force-pushed
the
feature/url-case
branch
from
3c8eeca
to
f582d53
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #167.
This is probably going to need some thorough testing once we have some translations in place.