-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move petition CTA above the fold on campaign page mobile views #10920
Comments
We might consider splitting this as well, maybe assigning to an overarching petition page improvements epic. Suggested ticket ideas:
|
@mtdenton thanks for making this! I added the |
Also noting we need to decide next steps for the sticky CTA button #10896 (comment) And make sure this won't affect the newsletter sign up snippet position? Particularly on mozfest site (if any changes happen, we need approval from Marc). Keeping in mind that ideally, our UX patterns are as consistent as possible. |
@Gbaldassano @mtdenton for the quick fix, can you please confirm both with the stakeholders and with the code re: the comment above about the sticky button on mobile? |
@nancyt1 had mocked up this version that is the same dev-wise as the original comment but she's suggesting stakeholders make use of the snippet copy to give supporters more context: |
We could change the code in For posterity, the JavaScript I'm referring to is here-ish:
|
Thanks @mtdenton! And that won't be too buggy/glitchy? Will it only affect petitions and not newsletter sign up CTAs? |
You bet! There shouldn't be any reason for it to behave strangely from my POV but we can evaluate. I'm also thinking that we can rewrite this JavaScript to determine if it's on a petition page or not and act accordingly so that newsletter sign up CTAs won't be affected. |
Great! cc @mmmavis |
Re-checking on staging for launch after un-reverting, looks good to go |
via @Gbaldassano, split from #10896
Stakeholder: needs grooming
Context
Optimizing the Petition forms to maximize conversions is a priority for the Engagement team. As a result, they would like us to move the petition form/CTA up so it appears above the fold on mobile (similar to what was done for donate forms)
However, there are some considerations to take into account:
order
sort of like we did in donate-wagtail #1755. Theh1
page title will need to be independent of the current top paragraphdiv
and always remain at the top of the page despite the order of the other elements.I've mocked up what this could look like but omitted needed input from the design team on arrangement, margin/padding, etc. (cc @kristinashu):
This takes the liberty of removing a few elements that were causing spacing issues:
div
s, we'll need input on what to do with these as well:The text was updated successfully, but these errors were encountered: