Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight component's decription should be wrapped in <p></p> #4287

Closed
mmmavis opened this issue Mar 3, 2020 · 0 comments · Fixed by #4360
Closed

Highlight component's decription should be wrapped in <p></p> #4287

mmmavis opened this issue Mar 3, 2020 · 0 comments · Fixed by #4360
Assignees
Milestone

Comments

@mmmavis
Copy link
Collaborator

mmmavis commented Mar 3, 2020

Context:
See ##4263 (comment)

Highlight component's description is a TextField but currently rendered as rich text. We should make sure the description is wrapped in <p></p> for semantic purposes and for the right style to kick in.

Relevant code to look at
https://github.com/mozilla/foundation.mozilla.org/blob/master/network-api/networkapi/wagtailpages/templates/wagtailpages/tags/card.html#L14
Since this template is used by different components, we shouldn't assume description is always in rich text format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants