Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/9282 stats block #11534

Merged
merged 7 commits into from
Dec 14, 2023

Conversation

kevinhowbrook
Copy link
Contributor

@kevinhowbrook kevinhowbrook commented Dec 12, 2023

Description

⚠️ This PR is based off https://github.com/MozillaFoundation/foundation.mozilla.org/pull/11532/files

This PR adds a new Stats block specifically for the mozfest site:

image

Link to sample test page: after running inv new-env the mozfest homepage and landing page should show stats blocks. http://mozfest.localhost:8000/en/
Related PRs/issues: https://torchbox.monday.com/boards/1334760528/pulses/1336799828

Checklist

Tests

  • Is the code I'm adding covered by tests?

Changes in Models:

  • Did I update or add new fake data?
  • Did I squash my migration?
  • Are my changes backward-compatible. If not, did I schedule a deploy with the rest of the team?

Documentation:

  • Is my code documented?
  • Did I update the READMEs or wagtail documentation?

Merge Method
💡❗Remember to use squash merge when merging non-feature branches into main

@kevinhowbrook kevinhowbrook force-pushed the feature/9282-stats-block branch from f58a94b to e7ca9c7 Compare December 13, 2023 12:54
@kevinhowbrook kevinhowbrook changed the base branch from feature/1300-card-grid-block to feature/5225-stats-block-FE December 13, 2023 12:55
@kevinhowbrook kevinhowbrook marked this pull request as ready for review December 13, 2023 12:55
Copy link
Collaborator

@tbrlpld tbrlpld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @kevinhowbrook. Just minor questions about the file structure.

network-api/networkapi/mozfest/customblocks/stats_block.py Outdated Show resolved Hide resolved
network-api/networkapi/mozfest/customblocks/__init__.py Outdated Show resolved Hide resolved
network-api/networkapi/mozfest/customblocks/stats_block.py Outdated Show resolved Hide resolved
network-api/networkapi/mozfest/customblocks/stats_block.py Outdated Show resolved Hide resolved
@chris-lawton chris-lawton force-pushed the feature/5225-stats-block-FE branch from 76821f3 to ba4089f Compare December 14, 2023 10:05
Base automatically changed from feature/5225-stats-block-FE to integration/mozfest-2024 December 14, 2023 10:19
@kevinhowbrook kevinhowbrook merged commit 2840663 into integration/mozfest-2024 Dec 14, 2023
4 checks passed
@kevinhowbrook kevinhowbrook deleted the feature/9282-stats-block branch December 14, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants