-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/9282 stats block #11534
Merged
kevinhowbrook
merged 7 commits into
integration/mozfest-2024
from
feature/9282-stats-block
Dec 14, 2023
Merged
Feature/9282 stats block #11534
kevinhowbrook
merged 7 commits into
integration/mozfest-2024
from
feature/9282-stats-block
Dec 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinhowbrook
force-pushed
the
feature/9282-stats-block
branch
from
December 13, 2023 12:54
f58a94b
to
e7ca9c7
Compare
kevinhowbrook
changed the base branch from
feature/1300-card-grid-block
to
feature/5225-stats-block-FE
December 13, 2023 12:55
tbrlpld
approved these changes
Dec 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @kevinhowbrook. Just minor questions about the file structure.
chris-lawton
force-pushed
the
feature/5225-stats-block-FE
branch
from
December 14, 2023 10:05
76821f3
to
ba4089f
Compare
Base automatically changed from
feature/5225-stats-block-FE
to
integration/mozfest-2024
December 14, 2023 10:19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new Stats block specifically for the mozfest site:
Link to sample test page: after running
inv new-env
the mozfest homepage and landing page should show stats blocks. http://mozfest.localhost:8000/en/Related PRs/issues: https://torchbox.monday.com/boards/1334760528/pulses/1336799828
Checklist
Tests
Changes in Models:
Documentation:
Merge Method
💡❗Remember to use squash merge when merging non-feature branches into
main