updated margin below DonateLandingPage featured image #11707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielfmiranda
temporarily deployed
to
foundation-s-feature-10-lyr5pm
|
Hi @danielfmiranda , from the code and the rendered page, it seems like on both mobile and desktop, the margin is 24px. Maybe I'm looking at the wrong place? 
|
nancyt1
approved these changes
Jan 10, 2024
danielfmiranda
temporarily deployed
to
foundation-s-feature-10-lyr5pm
|
Thanks for the catch @mmmavis! After taking a look, I found that I have actually gotten the spacing confused. According to the mockups that Nancy linked in #10364, the spacing should be:
I have updated the image with the following classes |
nancyt1
approved these changes
Jan 11, 2024
danielfmiranda
temporarily deployed
to
foundation-s-feature-10-lyr5pm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Link to sample test page: https://foundation-s-feature-10-lyr5pm.herokuapp.com/en/donate/
Related PRs/issues: #10364
This PR updates the margin below the Donate Landing Page's "featured image" to
tw-mb-12.Per request of design, this update:
32pxbetween the featured image and page title on mobile24pxbetween the featured image and the page intro on tablet16pxbetween the featured image and the page intro on tabletScreenshots:
Before:
Mobile Spacing (Note the gap of ~24px):
Desktop Spacing (Note the gap of ~16px):
After:
Mobile Spacing (Note the updated gap of ~32px):
Tablet Spacing (Note the updated gap of ~24px):
Desktop Spacing (Note the updated gap of ~16px):