-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup LinkBlock
to handle multiple types of links
#11954
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks @jhonatan-lopes !
Hi @jhonatan-lopes, I noticed this PR introduces new strings in network-api/networkapi/wagtailpages/factory/customblocks/link_block.py, before I expose them in Pontoon, I wanted to check whether actually translating these strings would be helpful for these tests, and if not, whether we should hardcode the strings, or even maybe exclude all test folders from the makemessages command? |
Hey @TheoChevalier, don't bother exposing them to Pontoon just yet. These strings are only used on the admin interface so there's no need for localisation (or a lower priority need). The tests need it because the So, moving forward I'll either remove those strings (by removing the library) or I'll try to exclude the test folders from the |
Description
Setup
wagtail-link-block
with a customLinkBlock
to handle multiple types of links:Old
LinkButton
interface (doesn't allowmailto:
links):New interface:
Link to sample test page:
Related PRs/issues: #11875
Checklist
Tests
Changes in Models:
Documentation:
Merge Method
💡❗Remember to use squash merge when merging non-feature branches into
main
┆Issue is synchronized with this Jira Story