-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "wide" option to article TableBlock #12843
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @robdivincenzo!!
Thanks for taking this on. The PR is looking great, and I can confirm that everything is working as expected! 👍
I’ve left a question I have regarding the table width on medium breakpoints and below, as well as some other minor suggestions.
Let me know what you think, thanks again!
network-api/networkapi/wagtailpages/templates/wagtailpages/blocks/wide_table_block.html
Outdated
Show resolved
Hide resolved
network-api/networkapi/wagtailpages/pagemodels/customblocks/table_block.py
Show resolved
Hide resolved
network-api/networkapi/wagtailpages/migrations/0160_alter_articlepage_body.py
Outdated
Show resolved
Hide resolved
network-api/networkapi/wagtailpages/templates/wagtailpages/blocks/wide_table_block.html
Show resolved
Hide resolved
network-api/networkapi/wagtailpages/templates/wagtailpages/blocks/wide_table_block.html
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @robdivincenzo!
LGTM 🚀
Description
This PR will create a new
WideTableBlock
on article pages with a checkbox so that users can select a table width of either wider than page content (checked by default), or the same width as page content (unchecked by default).The editor experience remains the same, except the addition of now having a checkbox to change the table width.
Related PRs/issues: TP1-144 / #10332
To Test
This is a little tricky because I was only able to find privately published examples of basic tables on articles.
main
inv copy-stage-db
/cms/
Public
and publish the pageTP1-144-10332-add-wide-table-block
(you may also need a new stage db)inv migrate
Wide
option now exists and is checked by default.docker-compose up
in order to get new tailwind classes┆Issue is synchronized with this Jira Story