-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove the thumb icons from the homepage #2207
Conversation
Now that we have a min-seal, removing the thumbs makes products without a seal look ... off center? Maybe that's not a problem, but something to look at before we decide to land this. |
I see what you mean. This PR is good but would need to revisit mini seal PR. Do you have to add that extra gray bar? I think the seal can fit within the gray border that surrounds the entire image. |
PR updated, we'll have to see what it looks like with some actual images on staging =) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah cool! Might need to make product images a little smaller but let's see.
ffc0a24
to
5b00491
Compare
…zilla.org into remove-home-thumbs
I've update the PR so that when filtering for likely/unlikely, the thumbs are revealed again, and default/filter:both hides them integrally. |
@mavis added you for code review, since this PR also updates how the filter works: as long as the filter is set to "both" for buying likelihood, there will not be any thumb up/down icons shown. When someone picks "likely" or "not lilkely", the appropriate icon is shown on all the resultant products. Also since it's technically possible to not have a recommendation HTML element, I added an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! That works great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Closes ##2197