Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YouTube Regrets - newsletter button and style tweaks #3754

Merged
merged 8 commits into from
Oct 10, 2019

Conversation

mmmavis
Copy link
Collaborator

@mmmavis mmmavis commented Oct 8, 2019

Closes #3726
Closes #3727

https://foundation-mofostaging-pr-3754.herokuapp.com/en/campaigns/youtube-regrets/

Added newsletter button (desktop only), MVP tweaks, and some nice-to-have changes.

@patjouk patjouk temporarily deployed to foundation-mofostaging-pr-3754 October 8, 2019 21:19 Inactive
@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-3754 October 8, 2019 21:21 Inactive
@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-3754 October 8, 2019 21:24 Inactive
@mmmavis mmmavis requested a review from kristinashu October 8, 2019 21:38
@kristinashu
Copy link

So this included:

  • adding Newsletter to desktop
  • centering the scroll icon

If so those two things look good!

One nice-to-have if it's easy to do would be if the clicking the Newsletter signup button in the main nav could close the signup form.

@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-3754 October 8, 2019 22:03 Inactive
@mmmavis
Copy link
Collaborator Author

mmmavis commented Oct 8, 2019

@kristinashu 👀 ?

Copy link

@kristinashu kristinashu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@mmmavis mmmavis requested a review from Pomax October 8, 2019 22:09
@kristinashu
Copy link

I've opened a follow up ticket - YouTube: add newsletter signup to mobile #3756

@Pomax
Copy link
Contributor

Pomax commented Oct 10, 2019

on desktop it looks like there's a very large "empty gap" between the end of the "tunnel" and the first actual content item. Is that because this is on staging, or would that still show up on staging/prod?

On a perhaps untested desing point, computer with mouse-wheel based scrolling, rather than touchpad/magic mouse scrolling, the "join mozlla" button is almost always darker than the text above it, and so it feels like a constantly out-of-place element. Does it make sense to separate the button from the content a bit more? (e.g. moving it down to 3/4 view height rather than keeping it close to the text?)

(On that note, does it make sense to make the button fade out with the last piece of text, too?)

@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-3754 October 10, 2019 16:53 Inactive
@mmmavis
Copy link
Collaborator Author

mmmavis commented Oct 10, 2019

on desktop it looks like there's a very large "empty gap" between the end of the "tunnel" and the first actual content item. Is that because this is on staging, or would that still show up on staging/prod?

I should be able to tweak that by changing the object moving speed with some factor.

On a perhaps untested desing point, computer with mouse-wheel based scrolling, rather than touchpad/magic mouse scrolling, the "join mozlla" button is almost always darker than the text above it, and so it feels like a constantly out-of-place element. Does it make sense to separate the button from the content a bit more? (e.g. moving it down to 3/4 view height rather than keeping it close to the text?)

Will need design feedback on this. Note that we'll need to leave sufficient room for the long text to show up properly ( e.g.,that sent them down a rabbit hole they never meant to go down and didn’t know how to stop).

(On that note, does it make sense to make the button fade out with the last piece of text, too?)

I went with the simplest solution to get stuff landed first. Can this be a follow-up? (Need design to chime in)

@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-3754 October 10, 2019 19:26 Inactive
@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-3754 October 10, 2019 19:33 Inactive
@mmmavis mmmavis merged commit b49fd57 into master Oct 10, 2019
@mmmavis mmmavis deleted the youtube-newsletter-button-n-style-tweaks branch November 21, 2019 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

YouTube: small style fixes YouTube: add newsletter signup
4 participants