-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add helper command to extract strings to an external repo #4199
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a few code styling errors to fix: https://travis-ci.org/mozilla/foundation.mozilla.org/jobs/650100919#L252-L255
It's not a blocker, but adding a small paragraph with a link to the l1on repo and how to import/export translations would be useful for devs. It could be a new file in the docs directory or in the main readme.
Thanks! Fixed the tests, and added some doc in the readme |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good! The review app is failing for now because compilemessages
is compiling all the .po
files from the virtualenv oO, but that's no need to worry/investigate since we're removing that step.
Let's merge the code that use the new translations archive, and then this PR.
84bb62c
to
9c6cf2e
Compare
…running compilemessages
This is related to MozillaFoundation/mofo-devops#735
Once the new workflow is live, translation files will live in an external repo. The string extraction will still happen in this repo, so this PR adds a script facilitating the string extraction.
It knows where to find the external repo via an env var. Mine looks like
LOCAL_PATH_TO_L10N_REPO=/Users/theochevalier/Documents/GitHub/fomo-l10n/
What the script does:
fomo-l10n
repo to the right places in your localfoundation.mozilla.org
repomakemessages
to update all .po filesfomo-l10n
repoThen if everything looks right, I can easily commit & push the updates to
fomo-l10n