Support ISO 3166 locale codes #4316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheoChevalier
force-pushed
the
iso-3166-locales
branch
from
0a5a274
to
dd3353e
Compare
TheoChevalier
force-pushed
the
iso-3166-locales
branch
from
dd3353e
to
c4da17c
Compare
TheoChevalier
force-pushed
the
iso-3166-locales
branch
from
c4da17c
to
b390d80
Compare
TheoChevalier
force-pushed
the
iso-3166-locales
branch
2 times, most recently
from
99508c9
to
17a99ac
Compare
TheoChevalier
force-pushed
the
iso-3166-locales
branch
from
17a99ac
to
bb57301
Compare
|
@TheoChevalier we can probably land this soon, I rebased and fixed the migrations (because we did a significant squashing since this PR got opened, so the migration dependencies had completely changed), but there's only the two comments. |
Co-authored-by: Pomax <pomax@nihongoresources.com>
|
@Pomax Thank you! And sorry I haven’t had much time to look into this today |
|
@TheoChevalier let's get this landed before the end of this week? =) |
|
@Pomax Sorry for the wait, finally took the time to file https://code.djangoproject.com/ticket/31795 |
Pomax
approved these changes
Jul 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4314
ab-CDlocale codes.pt-BRlater on (if there’s a way to migrate).fy-NLin order to test things easily, and because we would like to support it on the MozFest site.I’ve made mytranslation_management.shscript dynamic to support a list of locales that need to be copied fromab-CDintoab_CDduring Django string extraction process.UPDATE: I managed to leverage relative symlinks in the
fomo-1l0nrepo to entirely get rid of moving files betweenab-CDandab_CDfolders. Or even toptfor Portuguese.Most of the code comes from these two commits:
MozillaFoundation/donate-wagtail@f582d53
MozillaFoundation/donate-wagtail@d3bfd00
Adding Pomax as reviewer, since he reviewed the original fix