Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dedicated campaign index page extension on index page #4334

Merged
merged 6 commits into from
Mar 12, 2020
Merged

Dedicated campaign index page extension on index page #4334

merged 6 commits into from
Mar 12, 2020

Conversation

Pomax
Copy link
Contributor

@Pomax Pomax commented Mar 11, 2020 •
edited
Loading

Builds on top of #4333

Closes #4234 by making a dedicated campaign index page that only allows five (which should be four, but we need to keep BlogPage in for now).

@Pomax Pomax requested a review from mmmavis March 11, 2020 19:26
@patjouk patjouk temporarily deployed to foundation-s-campaignin-ybutif March 11, 2020 19:26 Inactive
@Pomax Pomax removed the request for review from mmmavis March 11, 2020 19:27
@Pomax Pomax changed the title dedicated campaign index page extension on index page [wip] dedicated campaign index page extension on index page Mar 11, 2020
@Pomax Pomax requested a review from mmmavis March 11, 2020 20:58
@Pomax Pomax temporarily deployed to foundation-s-campaignin-ybutif March 11, 2020 20:58 Inactive
@Pomax Pomax temporarily deployed to foundation-s-campaignin-ybutif March 12, 2020 16:06 Inactive
@Pomax Pomax temporarily deployed to foundation-s-campaignin-ybutif March 12, 2020 21:07 Inactive
@Pomax Pomax temporarily deployed to foundation-s-campaignin-ybutif March 12, 2020 21:07 Inactive
@Pomax Pomax temporarily deployed to foundation-s-campaignin-ybutif March 12, 2020 21:10 Inactive
mmmavis
mmmavis requested changes Mar 12, 2020
View reviewed changes
Copy link
Collaborator

@mmmavis mmmavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good!

/campaigns is 404 now because that page is on draft mode. Can we make factory create and publish that page?

@mmmavis mmmavis self-requested a review March 12, 2020 23:07
mmmavis
mmmavis approved these changes Mar 12, 2020
View reviewed changes
Copy link
Collaborator

@mmmavis mmmavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

R+

I will file a new ticket to update factory so it publishes the Campaign index page (/campaigns).

@Pomax Pomax changed the title [wip] dedicated campaign index page extension on index page Dedicated campaign index page extension on index page Mar 12, 2020
@Pomax Pomax merged commit 73f9f11 into master Mar 12, 2020
@Pomax Pomax deleted the campaignindex branch March 12, 2020 23:20
@TheoChevalier TheoChevalier mentioned this pull request Mar 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmmavis mmmavis mmmavis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a campaign index subclass of the IndexPage
3 participants
@Pomax @mmmavis @patjouk