Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

6527 Clean up _forms.scss #7167

Merged
merged 2 commits into from
Aug 4, 2021
Merged

6527 Clean up _forms.scss #7167

merged 2 commits into from
Aug 4, 2021

Conversation

fessehaye
Copy link
Contributor

Closes #6527

classes in _forms.scss were only used in the join and petition component so I just moved everything to those files.

@mofodevops mofodevops temporarily deployed to foundation-s-6527-forms-i8lb8r August 3, 2021 20:29 Inactive
@github-actions
Copy link

github-actions bot commented Aug 3, 2021

This PR introduces visual differences. Click here to inspect the diffs.

danielfmiranda
danielfmiranda approved these changes Aug 4, 2021
View reviewed changes
Copy link
Collaborator

@danielfmiranda danielfmiranda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Simon! Thanks for taking the time to tackle this and also for tagging me for review.

I just gave the code and percy a look through, and everything looks good to me!

Approving 👍

@mofodevops mofodevops temporarily deployed to foundation-s-6527-forms-i8lb8r August 4, 2021 19:15 Inactive
@fessehaye fessehaye merged commit 4644ecd into master Aug 4, 2021
@fessehaye fessehaye deleted the 6527-forms branch August 4, 2021 19:26
@github-actions
Copy link

github-actions bot commented Aug 4, 2021

This PR introduces visual differences. Click here to inspect the diffs.

@data-sync-user data-sync-user mentioned this pull request Jun 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielfmiranda danielfmiranda danielfmiranda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SCSS] Clean up _forms.scss
3 participants
@fessehaye @danielfmiranda @mofodevops