Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added word breaks to make sure links do not overflow. #7352

Merged
merged 1 commit into from
Sep 9, 2021

Conversation

danielfmiranda
Copy link
Collaborator

@danielfmiranda danielfmiranda commented Sep 9, 2021

Closes #7351

Link to sample test page: https://foundation-s-link-overf-lhi9bz.herokuapp.com/en/publication-page-with-child-article-pages/fixed-title-article-page/

Steps to test:

  1. Visit the link above, which is a page where I have copied and pasted the same "References" section that was producing the bug.
  2. Verify that there is no longer the ability to scroll to the right on mobile widths.
  3. If so, and everything else looks correct, testing is complete!

This is a fix for the bug in which links in content blocks of publication pages are overflowing and causing the page to be wider than the actual content.

Since this is only occuring in the "rich text" blogs of article/publication pages and everything else is working correctly, I have added a new CSS rule stating that links that go beyond the page width should break and stay within the container.

@mofodevops mofodevops temporarily deployed to foundation-s-link-overf-lhi9bz September 9, 2021 23:14 Inactive
@github-actions
Copy link

github-actions bot commented Sep 9, 2021

This PR introduces visual differences. Click here to inspect the diffs.

Copy link
Contributor

@Pomax Pomax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, that works quite well

@Pomax Pomax merged commit 54e3e2e into master Sep 9, 2021
@Pomax Pomax deleted the link-overflow-fix branch September 9, 2021 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

links are overflowing on publication pages
3 participants