7393 - Update content width #7405
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabrinang
reviewed
Sep 17, 2021
There was a problem hiding this comment.
@fessehaye Which specific product page URL in the deployment should review? When I click on a product it is Bad Request (400) for me.
danielfmiranda
approved these changes
Sep 20, 2021
sabrinang
previously requested changes
Sep 20, 2021
There was a problem hiding this comment.
The text contents/updates/related products should align with the 8 col grid so it seems should be a bit wider:
(I used a bootstrap grid overlay browser extension to check)
In the figma mockup, you can also go to View > Show Layout Grids for alignment reference
fessehaye
force-pushed
the
7393-content-width
branch
from
4c6e700
to
4106be9
Compare
fessehaye
force-pushed
the
7393-content-width
branch
from
4106be9
to
6502670
Compare
sabrinang
previously requested changes
Sep 24, 2021
There was a problem hiding this comment.
- the cut out sections can align to the edge of column 2 and 11 for the top section and dotted banner below
- the content below the dotted banner will be the same width as the content above to align with edge of column 3 and 10 as you have updated it
- highlighted in pink lines for your reference
fessehaye
force-pushed
the
7393-content-width
branch
from
6502670
to
aa2272c
Compare
sabrinang
previously requested changes
Sep 28, 2021
fessehaye
force-pushed
the
7393-content-width
branch
from
aa2272c
to
2919018
Compare
Fixed padding revision Changes Updates
fessehaye
force-pushed
the
7393-content-width
branch
from
2919018
to
4c3d777
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7393