Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the missing FilterField for localized snippet filtering #7414

Merged
merged 2 commits into from
Sep 20, 2021

Conversation

Pomax
Copy link
Contributor

@Pomax Pomax commented Sep 20, 2021

Closes #7398

Without this fix, the server will throw the following error when DEBUG is set to True:

image

And thankfully the error just tells us what the solution is =)

(although I don't know why it just doesn't "do that" without us having to write code, if it already knows both what's wrong, and what the fix is...)

Copy link
Collaborator

@danielfmiranda danielfmiranda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Pomax! Looks good to me, I am approving 👍

@Pomax Pomax merged commit 0fa7ee2 into main Sep 20, 2021
@Pomax Pomax deleted the pni-update-filter branch September 20, 2021 17:39
@Pomax Pomax temporarily deployed to foundation-s-pni-update-xowdmd September 20, 2021 17:39 Inactive
@github-actions
Copy link

This PR introduces visual differences. Click here to inspect the diffs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PNI: Search in Snippets --> Buyers Guide Product Updates Returns Server Error (500)
3 participants