Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7434] - FE/BE Structured data field for Mozfest pages #7568

Merged
merged 26 commits into from
Jan 26, 2022

Conversation

stevedya
Copy link
Collaborator

@stevedya stevedya commented Oct 5, 2021

Closes #7535, #7536 , #7434

Implementation Checklist:

  • Text field in Promote tab where JSON can be added
  • Add link to Structured Data tester in help text
  • Print out schema into a block in the template
  • Ensure structured data is stripped of all tags

Of Note:

  • Commented out a line in an old migration because it was causing issues with the CI. Please see this comment for details.

Changes in Models:

  • Did I squash my migration?

Screenshots:

Putting valid Structured Data JSON will be properly detected by tools used to check Structured Data.

image

Screen Shot 2021-10-21 at 10 55 23 PM

Putting potentially malicious <script> tags (or invalid JSON) will just cause the Structured Data to be invalid but will not affect the user.

image

@stevedya stevedya requested a review from b-ggs October 5, 2021 20:31
@mofodevops mofodevops temporarily deployed to foundation-s-feature-75-jgqslo October 5, 2021 20:31 Inactive
@github-actions
Copy link

github-actions bot commented Oct 5, 2021

This PR introduces visual differences. Click here to inspect the diffs.

@Pomax Pomax temporarily deployed to foundation-s-feature-75-2xbrnl October 6, 2021 21:11 Inactive
@b-ggs
Copy link
Collaborator

b-ggs commented Oct 6, 2021

Mistakenly closed, apologies.

@b-ggs b-ggs closed this Oct 6, 2021
@b-ggs
Copy link
Collaborator

b-ggs commented Oct 6, 2021

Mistakenly closed, apologies.

@github-actions
Copy link

github-actions bot commented Oct 6, 2021

This PR introduces visual differences. Click here to inspect the diffs.

@stevedya stevedya requested a review from Pomax October 6, 2021 22:33
@Pomax
Copy link
Contributor

Pomax commented Oct 12, 2021

I notice this is still a draft with CI failing, I'll unmark myself for review for now, please reflag me when this PR is ready for review?

@Pomax Pomax removed their request for review October 12, 2021 20:05
@stevedya stevedya marked this pull request as ready for review October 14, 2021 21:17
@stevedya
Copy link
Collaborator Author

Hey @Pomax you can take a look now whenever you get the chance 🙂 I may need @b-ggs's assistance with these CI fails as well.

@stevedya stevedya requested a review from Pomax October 14, 2021 21:19
@stevedya stevedya self-assigned this Oct 14, 2021
@github-actions
Copy link

This PR introduces visual differences. Click here to inspect the diffs.

@github-actions
Copy link

This PR introduces visual differences. Click here to inspect the diffs.

@b-ggs
Copy link
Collaborator

b-ggs commented Oct 15, 2021

Unassigning Pomax from this for now. Need to look into why the Wagtail CI along with the others are failing.

@b-ggs b-ggs removed request for b-ggs and Pomax October 15, 2021 16:45
@mofodevops mofodevops temporarily deployed to foundation-s-feature-75-ahlutl December 13, 2021 17:02 Inactive
@mofodevops mofodevops temporarily deployed to foundation-s-feature-75-ahlutl December 13, 2021 17:21 Inactive
@mofodevops mofodevops temporarily deployed to foundation-s-feature-75-ahlutl December 14, 2021 16:16 Inactive
@mofodevops mofodevops temporarily deployed to foundation-s-feature-75-ahlutl December 14, 2021 16:36 Inactive
@mofodevops mofodevops temporarily deployed to foundation-s-feature-75-ahlutl December 16, 2021 12:09 Inactive
@mofodevops mofodevops temporarily deployed to foundation-s-feature-75-ahlutl December 16, 2021 12:49 Inactive
@richbrennan
Copy link
Contributor

richbrennan commented Dec 16, 2021

@Pomax

I don't think Sabrina's review is required now that Marc has approved it, can this be merged (code freeze depending)?

@sabrinang
Copy link

+1 you can remove me as reviewer since Marc has reviewed/approved.

@Pomax
Copy link
Contributor

Pomax commented Dec 21, 2021

approved, but holding off landing until we're out of code freeze

@Pomax Pomax self-requested a review January 20, 2022 22:28
Copy link
Contributor

@Pomax Pomax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

migration numbering updatred, and reapproved for post-code-unfreeze merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BE: Mozfest Event Structured Data - Add field to Promote Tab
9 participants