-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[7434] - FE/BE Structured data field for Mozfest pages #7568
Conversation
This PR introduces visual differences. Click here to inspect the diffs. |
Mistakenly closed, apologies. |
Mistakenly closed, apologies. |
This PR introduces visual differences. Click here to inspect the diffs. |
I notice this is still a draft with CI failing, I'll unmark myself for review for now, please reflag me when this PR is ready for review? |
This PR introduces visual differences. Click here to inspect the diffs. |
This PR introduces visual differences. Click here to inspect the diffs. |
Unassigning Pomax from this for now. Need to look into why the Wagtail CI along with the others are failing. |
This reverts commit 99230c3.
I don't think Sabrina's review is required now that Marc has approved it, can this be merged (code freeze depending)? |
+1 you can remove me as reviewer since Marc has reviewed/approved. |
approved, but holding off landing until we're out of code freeze |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
migration numbering updatred, and reapproved for post-code-unfreeze merge
Closes #7535, #7536 , #7434
Implementation Checklist:
Of Note:
Changes in Models:
Screenshots:
Putting valid Structured Data JSON will be properly detected by tools used to check Structured Data.
Putting potentially malicious
<script>
tags (or invalid JSON) will just cause the Structured Data to be invalid but will not affect the user.