Use non-API requests to fetch GitHub release versions (#28)

MozillaSecurity · Oct 24, 2018 · fdb23a5 · fdb23a5
1 parent 8f6bc19
commit fdb23a5
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 8 deletions.
diff --git a/base/fuzzos/recipes/common.sh b/base/fuzzos/recipes/common.sh
@@ -34,8 +34,9 @@ function apt-install-auto () {
 }
 
 function get-latest-github-release () {
+  # Bypass GitHub API RateLimit. Note that we do not follow the redirect.
   # shellcheck disable=SC2016
-  curl -Ls "https://api.github.com/repos/$1/releases/latest" | rg -Nor '$1' '"tag_name": "(.+)"'
+  retry curl -s "https://github.com/$1/releases/latest" | rg -Nor '$1' 'tag/(.+)"'
 }
 
 # In a chrooted 32-bit environment "uname -m" would still return 64-bit.

diff --git a/base/fuzzos/recipes/grcov.sh b/base/fuzzos/recipes/grcov.sh
@@ -6,8 +6,8 @@ source ./recipes/common.sh
 #### Install grcov
 
 PLATFORM="linux-x86_64"
-LATEST_VERSION=$(get-latest-github-release "marco-c/grcov")
-retry curl -LO "https://github.com/marco-c/grcov/releases/download/$LATEST_VERSION/grcov-$PLATFORM.tar.bz2"
+LATEST_VERSION=$(get-latest-github-release "mozilla/grcov")
+retry curl -LO "https://github.com/mozilla/grcov/releases/download/$LATEST_VERSION/grcov-$PLATFORM.tar.bz2"
 tar xf grcov-$PLATFORM.tar.bz2
 install grcov /usr/local/bin/grcov
 rm grcov grcov-$PLATFORM.tar.bz2
diff --git a/base/fuzzos/recipes/rg.sh b/base/fuzzos/recipes/rg.sh
@@ -5,7 +5,7 @@ source ./recipes/common.sh
 
 #### Install rg (ripgrep)
 
-LATEST_VERSION=$(curl -Ls 'https://api.github.com/repos/BurntSushi/ripgrep/releases/latest' | grep -Po '"tag_name": "\K.*?(?=")')
+LATEST_VERSION=$(curl -s "https://github.com/BurntSushi/ripgrep/releases/latest" | grep -o 'tag/[v.0-9]*' | awk -F/ '{print $2}')
 retry curl -LO "https://github.com/BurntSushi/ripgrep/releases/download/${LATEST_VERSION}/ripgrep_${LATEST_VERSION}_amd64.deb"
 apt install ./"ripgrep_${LATEST_VERSION}_amd64.deb"
 rm "ripgrep_${LATEST_VERSION}_amd64.deb"
diff --git a/services/linter/Dockerfile b/services/linter/Dockerfile
@@ -5,10 +5,10 @@ LABEL maintainer Christoph Diehl <cdiehl@mozilla.com>
 RUN apk --no-cache add \
     curl \
     && HADOLINT_VERSION=$( \
-        curl -sL 'https://api.github.com/repos/hadolint/hadolint/releases/latest' \
-        | grep '"tag_name":' \
-        | sed -E 's/.*"([^"]+)".*/\1/' \
-        ) \
+        curl -sL "https://github.com/hadolint/hadolint/releases/latest" \
+        | grep -o 'tag/[v.0-9]*' \
+        | awk -F/ '{print $2}' \
+    ) \
     && curl -sL -o /bin/hadolint "https://github.com/hadolint/hadolint/releases/download/$HADOLINT_VERSION/hadolint-Linux-x86_64" \
     && chmod +x /bin/hadolint \
     && curl -sL https://storage.googleapis.com/shellcheck/shellcheck-latest.linux.x86_64.tar.xz \