-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create akchilov3消灭一切打表式反射.cpp #251
Conversation
struct X
{
char cc{'k'};
int a{10};
char c{'l'};
char e{'3'};
double b{2.33};
};
使用以上结构体,偏移求解错误 https://gcc.godbolt.org/z/cqEW43Evz 偏移求解参考akchilov2.cpp:108 原来是一个人啊 人不能两次踏进同一条河流。 -- 赫拉克利特 |
你提交pr能不能不要搞这么抽象的名字,我看到都不知道是啥,你总得说明:
这样的 commit 丑的要死 |
等下,改改 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
改完再说
https://gcc.godbolt.org/z/b63qv93xb 测试了这个,应该是没有啥问题了吧。。。 |
struct X
{
char cc{ 'k' };
int a{ 10 };
char c{ 'l' };
short r{123};
char e{ 'u' };
int ac{ 19 };
double b{ 2.33 };
double bbg{ 4.55 };
}; error |
同步修改编译期版,修复位移越出对齐宽度时未重置偏移值和偏移层的问题
文件名用了空格(默认空格当路径分隔符 |
src/群友提交/第10题/akchilov3 第十题.cpp
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
你为什么要在文件名里特地强调“第十题”?文件名直接叫 akchilov3.cpp
就行。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
你为什么要在文件名里特地强调“第十题”?文件名直接叫
akchilov3.cpp
就行。
他阅读理解太夸张了,我让他 commit 和 pr 写第几题,他把文件名改了。
@AzrBrk 你修改好了就要自己 request for review。 |
@Matrix-A #251 (comment) 的这个问题是否还存在?review 一下。 |
还是存在的 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
问题在于,你这个 pr 的名字,还是不明确啊 |
还有四个 commit 的信息,瞎写 |
@Mq-b 不喜欢 PR 的 commit 信息可以 Squash and Merge。 |
更新: |
好复杂( |
已知问题:编译时运行版本无法推算聚合类内部有聚合类成员的情况,目前我不知道如何解决, std::is_constructible_v会为false,但是可以有非聚合类的结构体成员 |
那就可以了。另外要记得 request for review。@AzrBrk |
https://gcc.godbolt.org/z/qcqzaY1fa