涼風青葉提交第1，2，3题 #258
Merged
涼風青葉提交第1，2，3题 #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mq-b
reviewed
Jan 29, 2024
src/群友提交/第01题/涼風青葉.cpp
Outdated
| #include<functional> | ||
|
|
||
| template<typename T, typename Formatter> | ||
| T &operator|(T &arr, const Formatter &func) { |
There was a problem hiding this comment.
- 这个对齐真抽象。
- 既然明确的是返回和接取的是
std::vector，那没必要写T，写std::vector<T>不香吗？ Formatter模板类型形参的名字与实际作用不符。
Mq-b
reviewed
Jan 29, 2024
src/群友提交/第03题/涼風青葉.cpp
Outdated
| }; | ||
|
|
||
| template<typename T, typename ...U> | ||
| void print(T fmt, U ...args) { |
There was a problem hiding this comment.
T fmt, U ...args 极其不规范，应当改为 const T& fmt、Args&&...args。
src/群友提交/第03题/涼風青葉.cpp
Outdated
|
|
||
| template<typename T, typename ...U> | ||
| void print(T fmt, U ...args) { | ||
| std::cout << std::vformat(fmt, std::make_format_args(args...)); |
There was a problem hiding this comment.
args... 可以考虑形参包完美转发 std::forward<Args>(args)...。
虽然以前实测好像这里改用完美转发并不能提升效率，不过是习惯问题。
Mq-b
requested changes
Jan 29, 2024
| @@ -0,0 +1,16 @@ | |||
| #include<iostream> | |||
| #include<vector> | |||
| #include<functional> | |||
There was a problem hiding this comment.
缺少头文件 #include <algorithm> 无法在 msvc 通过编译。
Mq-b
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.