Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding unittest #1

Merged
merged 1 commit into from
Feb 9, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 46 additions & 1 deletion tests/test_charm.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,12 @@
# Learn more about testing at: https://juju.is/docs/sdk/testing

import unittest
from unittest.mock import Mock
from unittest.mock import Mock, patch, MagicMock

from charm import LldpdCharm
from ops.model import ActiveStatus
from ops.testing import Harness
from pathlib import Path


class TestCharm(unittest.TestCase):
Expand Down Expand Up @@ -66,3 +67,47 @@ def test_httpbin_pebble_ready(self):
self.assertTrue(service.is_running())
# Ensure we set an ActiveStatus with no message
self.assertEqual(self.harness.model.unit.status, ActiveStatus())

@patch('charm.Path')
@patch('charm.subprocess.run')
@patch('charm.logger')
def test_disable_i40e_lldp_without_i40e_nics(self, mock_logger, mock_subprocess, mock_path):
mock_path("/sys/class/net").iterdir.return_value = []

with self.assertRaises(SystemExit) as cm:
self.harness.charm.disable_i40e_lldp()

self.assertEqual(cm.exception.code, 0)
mock_logger.info.assert_called_with("Can't find any i40e NICs. Recommend setting the charm config i40e-lldp-stop to false")
mock_subprocess.assert_not_called()

@patch('charm.Path')
@patch('charm.subprocess.run')
@patch('charm.logger')
def test_disable_i40e_lldp_with_i40e_nics(self, mock_logger, mock_subprocess, mock_path):

nic_list = ["eth0", "eth1"]
mock_nics = []
for nic_name in nic_list:
mock_nic = MagicMock()
mock_nic.name = nic_name
mock_driver = mock_nic / "device/driver"
mock_driver.resolve.return_value = Path("/sys/class/net/{nic_name}/device/driver/i40e")
mock_nics.append(mock_nic)

mock_path("/sys/class/net").iterdir.return_value = mock_nics

self.harness.charm.disable_i40e_lldp()

expected_calls = [ unittest.mock.call([
'sudo',
'/usr/sbin/ethtool',
'--set-priv-flags',
nic_name,
'disable-fw-lldp',
'on'], check=True) for nic_name in nic_list]

mock_subprocess.assert_has_calls(expected_calls, any_order=True)

for nic_name in nic_list:
mock_logger.info.assert_any_call(f"Using ethtool(8) to disable FW lldp for {nic_name}")