Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue 52, use the right ProtoRemoveCommand #54

Merged
merged 1 commit into from
Sep 9, 2023
Merged

Fix issue 52, use the right ProtoRemoveCommand #54

merged 1 commit into from
Sep 9, 2023

Conversation

hafiidz
Copy link
Contributor

@hafiidz hafiidz commented Sep 4, 2023

Trying to to address issue #52 , which is using the wrong ProtoInsertCommand instead of ProtoRemoveCommand.

MrGVSV
MrGVSV approved these changes Sep 9, 2023
View reviewed changes
Copy link
Owner

@MrGVSV MrGVSV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@MrGVSV MrGVSV linked an issue Sep 9, 2023 that may be closed by this pull request
Fix ProtoCommands::remove inserting instead of removing #52
Closed
@MrGVSV MrGVSV merged commit 5bdefe1 into MrGVSV:main Sep 9, 2023
0 of 2 checks passed
@hafiidz hafiidz deleted the fix-proto-commands-remove branch September 10, 2023 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrGVSV MrGVSV MrGVSV approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix ProtoCommands::remove inserting instead of removing
2 participants
@hafiidz @MrGVSV