Bug fix: host description should not depend on settings, as this may …

…break the OFX plugins cache.
MrKepzie · Aug 17, 2016 · 32c1532 · 32c1532
1 parent b5e3b35
commit 32c1532
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/Engine/OfxHost.cpp b/Engine/OfxHost.cpp
@@ -299,11 +299,13 @@ OfxHost::setProperties()
     _properties.setIntProperty(kOfxParamHostPropPageRowColumnCount, 0, 1 );
     _properties.setIntProperty(kOfxImageEffectInstancePropSequentialRender, 2); // OFX 1.2
 #ifdef OFX_SUPPORTS_OPENGLRENDER
-    if (appPTR->getCurrentSettings()->isOpenGLRenderingEnabled()) {
-        _properties.setStringProperty(kOfxImageEffectPropOpenGLRenderSupported, "true"); // OFX 1.3
-    } else {
-        _properties.setStringProperty(kOfxImageEffectPropOpenGLRenderSupported, "false"); // OFX 1.3
-    }
+    // all host properties should be static and not depend on the settings, or the plugin cache may be wrong
+    _properties.setStringProperty(kOfxImageEffectPropOpenGLRenderSupported, "true"); // OFX 1.3
+    //if (appPTR->getCurrentSettings()->isOpenGLRenderingEnabled()) {
+    //    _properties.setStringProperty(kOfxImageEffectPropOpenGLRenderSupported, "true"); // OFX 1.3
+    //} else {
+    //    _properties.setStringProperty(kOfxImageEffectPropOpenGLRenderSupported, "false"); // OFX 1.3
+    //}
 #endif
     _properties.setIntProperty(kOfxImageEffectPropRenderQualityDraft, 1); // OFX 1.4
     _properties.setStringProperty(kOfxImageEffectHostPropNativeOrigin, kOfxHostNativeOriginBottomLeft); // OFX 1.4