-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gui cannot download some files that youtube-dl can #49
Comments
Hi @Pcsl Which version of youtube-dlg you are using? I was unable to download the url you gave me both with the latest version of youtube-dl and youtube-dlg. You should do the following:
|
I can download that link with youtube-dl 2015.07.07 without problems (I need ffmpeg in the same folder though). I tried to add the log here but the problem is that the task never stops, it just get stuck in "Downloading" and never ends so there's no way to view the log as it seems it's saved when the download terminates. |
Can you tell me which version of youtube-dlg you are using? Does this problem occurs every time you try to download the given url ? |
I'm using the last version 0.3.8 for Windows (portable). Yeah, that problems occurs every time (I tried more than 10 times).
|
The gui does not provide any info about the size, eta, download speed etc. because those informations are not available neither on the youtube-dl. Now for the second issue with the stop button, i was able to reproduce it using a proxy. Also, the download process never stops both on Windows and Linux. I will take a closer look on this. |
Thanks for your work! |
There were two different bugs. Both bugs had more or less to do with the hls downloader and the usage of ffmpeg The first bug was that the subprocess module was deadlocking due to the large amount of ffmpeg output in the stderr pipe which had as a result to freeze the download process (this issue is now fixed both on Windows and Linux using a seperate thread to read from the stderr pipe). The second bug was that currently there is no way to kill the whole process group using the subprocess module (see: https://bugs.python.org/issue5115). So basically the stop button kills only the youtube-dl process which leaves ffmpeg process as an orphan, which in turn makes youtube-dlg to wait for the completion of the ffmpeg process before it closes down itself. (If you use something like Process Explorer and pay attention to what is happening when you click the stop button you will get what i mean). This issue is now fixed on Linux using the os.killpg function. On Windows there is no easy way to terminate the whole process group using the subprocess module, so the stop button won't work when the hls downloader is used. In order to overcome this issue on Windows you can use the native hls downloader (does not use ffmpeg) by setting the I uploaded the patched version (it's not stable) here. I was able to successfully download your url using the patched version and by setting the Can you give it a try and let me know? |
Μore generally, you should be able to download any url that uses the hls downloader without setting the Notes
|
First of all I tried to download using the patched version without setting the --hls-prefer-native option. The download works now and shows 100% when it's finished, however the status says "Error". Anyway it's completed successfully, it's just that it says "Error" on the GUI. The Stop button doesn't finish the task here. Setting --hls-prefer-native works flawlessly, shows the percentage completed while it's downloading and the task it's completed succesfully too. It also shows "Error" at the Status column even if it were downloaded completely. Here there is no problem to stop the task. So yeah, it seems everything is working as you described. |
Everything seems fine except the Error status. You should check your log under Options > Log tab. Also, check if you have set the |
Yeah, you are right, if I remove the -v option the status is right, it just says "Finished". So it seems to be working fine now. |
Thanks for your report. |
Good job, great work! (Just a little bit of encouragement) |
Thank you @Hrxn 👊 |
Hello there,
I really like your software and find it very useful but I'm having problems to download some specific links, specifically from the platform this link comes from: http://www.mitele.es/programas-tv/este-hotel-es-un-desastre/temporada-1/programa-1/ . Using the command line interface from youtube-dl the files is download without problems but when I try to download it using your GUI, it got stuck in "Downloading" and doesn't show any speed, ETA, percent nor size. Actually I think that the files doesn't start to download. Apart from that when this happens, the button "STOP" doesn't work and can't close the program, I have to use the task manager to force close it.
I hope you can look into this.
The text was updated successfully, but these errors were encountered: