-
-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ConnectionDetails inconsistency all over application #25
Comments
A singleton should certainly be used to ensure only one access point for the connection file |
What about:
This way, each time a connection change (and the file is saved), every application that uses ConnectionManager class can be notified about a change. I tested it with creating a ConnectionDetail on a tool launch, and then opening connection control on the bottom left. It seems to work |
If it will work for you, I can offer you following approach: if you can push this code as separate branch to this repository and I will test it with all scenarios I have (luckily I'm working with all this connections functionality in And afterwards we can discuss results. |
Available on branch Issue25Branch |
Thanks!!! Overall basic scenarios works well, except one difference: create / edit connection dialog called from status bar has |
There some issues in presentation list of connection: When new connection is created from list of connection, the new entry added to the end of the list, when dialog closed and reopened new connection moves to the its place in alphabetical order. In the status bar this issue is not applicable, since list of connections is visible only when status bar is clicked, so visually there new connection appears in right place right away. |
I also can identify incorrect handling of custom password showed on edit connection form. If password was saved (checkmark set), and then we changed our mind and unset the checkmark, the password stays in the edit window even after pressing This actually leads to very strange behavior:
Definitely there is a way out — close Connection list and reopen it... But this is not the way how it should be done. |
👍 Thank you! |
It seems to be there is no one consistent approach to
ConnectionDetail
handling in XrmToolBox application.For example, on application start application reads information about available connections from configuration file. But when we opening first plugin, the system asks about connection to CRM and offers user to choose from the list of connection red from configuration file just now. So it reads file twice, and if it was changed, information is differs.
There is also strange behavior I cannot isolate for now: changes in connections list made in windows initiated from menu bar will not affect connections list that is called from status bar.
It also seems to be that connection information is updated in configuration file on program exit, while if it crashed due some reason, all changes will be lost.
Another thing that there is no event that fires when connection list is updated, thus if plugin works with the connection list it will not be notified about changes.
The text was updated successfully, but these errors were encountered: