Changes to prevent error with infopanel not disappearing. #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync From Original to My Fork
Refresh from XTB
…t, open a plugin, then attep to connect twice, before the first connection completes, two panels will be opened, and one will never close ConnectionManager.cs - Had to add a Parameter to be able to pass back the Popup Message MainForm.PluginsManagement - Added a chec to see if ther eis no constructor. The Tag has to be populated, or else a null ref exception will get thrown. Throw a better message earlier Added Error Logic handler if there is a Reflection Type Load Exception. FormHelper.cs - Added an overload for AskForConnection that accepts an Action that is called before the actual Async process is kicked off. This allows the message to be displayed before the actual call is made. ConnectionParameterInfo.cs - Class to help define the parameters sent in the connection call MainForm.cs - Removed infoPanel field, since there may be more than one open at a time. - Changed Parameter to be the info parameter - Changed the infoPanel to be set wihtin the ConnectUponApproval call
MscrmTools
added a commit
that referenced
this pull request
Sep 14, 2015
Changes to prevent error with infopanel not disappearing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to prevent error with infopanel not disapearing. Don't connect, open a plugin, then attep to connect twice, before the first connection completes, two panels will be opened, and one will never close. This does not fix the issue where the XTB doesn't work correctly when connecting first.
ConnectionManager.cs
MainForm.PluginsManagement
Added Error Logic handler if there is a Reflection Type Load Exception.
FormHelper.cs
ConnectionParameterInfo.cs
MainForm.cs