Embargo refactor #1910
Open
Embargo refactor #1910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes how embargoes are stored from two booleans:
embargoandpermanent_embargoto a single choice fieldembargo_statuswith possible values ofpublic,embargo, andpermanent. Both booleans being false corresponds topublic.embargobeing true andpermanent_embargobeing false corresponds toembargo. Both being true corresponds topermanent.embargobeing false andpermanent_embargobeing true is an illegal state which requests were somehow ending up in, and eliminating this illegal state is the main driver for this refactor. The idea here is that functionality should be unchanged, and just the underlying database representation is changed. The one exception is the API - it would be possible to make this work, but is somewhat complicated as django rest framework works on the database representation by default. Further, the plan is to replace this version of the API soon and I do not think people are using this, so it was deemed unnecessary.