Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: add macos packaging, build for multiple games #4

Merged
merged 8 commits into from
Jan 18, 2025

Conversation

jmckisson
Copy link
Contributor

@jmckisson jmckisson commented Jan 4, 2025

This adds AppDmg creation for macOS.
I have also added for macOS and Windows building for multiple games listed in the GameList.txt, just a few for now.
It essentially modifies the ini file that specifies the game to launch and rebuilds for each.. Technically a rebuild isn't needed just some copying of files after building the first, but this is working for now and I'll optimize later.

Currently unable to test this on my personal Mac as it is still running macOS 12

@vadi2
Copy link
Member

vadi2 commented Jan 4, 2025

I'll test this out on my mac! As a sidenote, try out dockur/macos. It doesn't run the quickest, but once you give it more than the default RAM / cores, it works "OK".

@vadi2
Copy link
Member

vadi2 commented Jan 4, 2025

It runs! 🌟

Trivial issue, the icon is missing:
Screenshot from 2025-01-04 16-05-26

The actual download didn't work, I'm not sure if that is correct or not:
Screenshot from 2025-01-04 16-06-06

@jmckisson
Copy link
Contributor Author

Ah hmm I'll investigate. I forgot I had it set to fetch PTB's which may be one issue but if it was listed in the feed but not a real download then it may be some other issue. I'll get the dockur thing up and running...

@jmckisson
Copy link
Contributor Author

Not sure what's going on with the icon, the mudletbootstrap-appdmg.json points to the correct file...
I switched the download mode to release and it now properly grabs the latest 4.19 release, the previous PTB download doesn't actually exist despite being the top listing in the public-test-build feed.

@jmckisson jmckisson changed the title Add: add macos packaging Add: add macos packaging, build for multiple games Jan 5, 2025
@vadi2
Copy link
Member

vadi2 commented Jan 17, 2025

Let's merge it for now? I'll start to add the signing.

@jmckisson
Copy link
Contributor Author

Ah, yea that sounds good, I was waiting for the Windows build to complete it was taking forever because the qt build cache expired

@jmckisson jmckisson marked this pull request as ready for review January 17, 2025 21:32
@vadi2 vadi2 merged commit f81cfd4 into Mudlet:development Jan 18, 2025
3 checks passed
@jmckisson jmckisson deleted the mac-appdmg branch January 18, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants