Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention how to find the root folder #31

Merged
merged 3 commits into from
Dec 3, 2024
Merged

Mention how to find the root folder #31

merged 3 commits into from
Dec 3, 2024

Conversation

za3k
Copy link
Contributor

@za3k za3k commented Jun 18, 2024 •
edited
Loading

@za3k za3k mentioned this pull request Jun 18, 2024
Open
1 task
Zetabite
Zetabite reviewed Jun 19, 2024
View reviewed changes
Directory-Structure.md Outdated Show resolved Hide resolved
Zetabite
Zetabite reviewed Jun 19, 2024
View reviewed changes
Directory-Structure.md Outdated Show resolved Hide resolved
Zetabite
Zetabite reviewed Jun 19, 2024
View reviewed changes
Directory-Structure.md Outdated Show resolved Hide resolved
@za3k
Copy link
Contributor Author

za3k commented Jun 19, 2024

@Zetabite Github has a feature where I believe you should be able to make changes to my PR yourself because I've given you permissions. For next time around.

The other small point I'll mention is that the docs say "Directory" consistently, but MultiMC itself says "Folder". I assume people know they're the same?

@Zetabite
Copy link

Zetabite commented Jun 19, 2024 •
edited
Loading

The other small point I'll mention is that the docs say "Directory" consistently, but MultiMC itself says "Folder". I assume people know they're the same?

Always in for consistency

@za3k
Copy link
Contributor Author

za3k commented Jun 19, 2024 •
edited
Loading

Always in for consistency

Sorry I'm not sure what this means.

@Zetabite
Copy link

You are welcome to make it more consistent

@za3k
Copy link
Contributor Author

za3k commented Jun 19, 2024

Done. Especially note that I changed the filename, in case any links need updated. Feel free to change the filename back yourself if you don't want to break things.

@peterix peterix merged commit 7170d97 into MultiMC:master Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zetabite Zetabite Zetabite left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@za3k @Zetabite @peterix