Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User registration improvements #141

Merged
merged 17 commits into from
Oct 22, 2020
Merged

User registration improvements #141

merged 17 commits into from
Oct 22, 2020

Conversation

multimeric
Copy link
Collaborator

@multimeric multimeric commented Oct 14, 2020

@ewels
Copy link
Member

ewels commented Oct 14, 2020

Wait, to disable the user confirmation step you set STRICT_REGISTRATION to true? That seems backwards..

@ewels
Copy link
Member

ewels commented Oct 14, 2020

Why not set USER_REGISTRATION_APPROVAL: false in the config yaml?

@multimeric
Copy link
Collaborator Author

Oh oops, it's like that because initially strict was opt-in, but now it's opt-out.

@multimeric multimeric marked this pull request as draft October 20, 2020 03:52
@multimeric multimeric marked this pull request as ready for review October 20, 2020 03:52
@multimeric
Copy link
Collaborator Author

Okay, I think I'm happy with this. Feel free to review.

@multimeric multimeric merged commit 28de87b into master Oct 22, 2020
@apeltzer apeltzer deleted the strict-registration branch November 26, 2020 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stable versioning and changelog User management page not working Limiting account creation
2 participants