Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix QualiMap MEAN/MEDIAN #1085

Merged
merged 4 commits into from
Apr 20, 2020
Merged

Fix QualiMap MEAN/MEDIAN #1085

merged 4 commits into from
Apr 20, 2020

Conversation

apeltzer
Copy link
Contributor

Hi,

this fixes a bug introduced in MultiQC v1.8 while adding the mean coverage computation to the QualiMap module output. Unfortunately, the break condition caused some errors and I had to split up the loop over the dictionary to two loops now to get this done correctly. I verified using the data in the #1082 issue and it looks like this fixed the problem.

multiqc_report.html.zip

If this PR is not a new module

@ewels
Copy link
Member

ewels commented Dec 18, 2019

This is maybe a little late to be asking this, but is there a reason that we can’t just take the value for mean coverage from the Qualimap output?

https://github.com/ewels/MultiQC_TestData/blob/310327cf2bbaa28b713f9b3e2e7c5b60b2e0ae74/data/modules/qualimap/bam_qc/ERR089819.qc/genome_results.txt#L61

@apeltzer
Copy link
Contributor Author

Sure, can do that - makes probably sense to do that. The median isn't there so its fine to compute that "by hand".

@apeltzer
Copy link
Contributor Author

done and adjusted 👍

@ewels ewels merged commit 9b92ae4 into MultiQC:master Apr 20, 2020
@ewels
Copy link
Member

ewels commented Apr 20, 2020

Tested and works. Thanks again @apeltzer!

@apeltzer apeltzer deleted the fix-qualimap branch April 20, 2020 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants