Remove y-value scaling #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicegamer7
force-pushed
the
remove_y_scaling
branch
from
f7edc48 to
a410c94
Compare
|
It looks like the y-value scaling was added in #100. From what I can tell, it wasn't added to help MV-NP match Vanilla behaviour, so I think it's fine to remove. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most likely fixes #244.
I believe the cause of the issue is the y-value scaling. It makes sense that this would show up in 1.18 given the min and max height changes.
edit: I checked the server code, and there's no scaling of the y-value in Vanilla.