-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests assertions #379
base: master
Are you sure you want to change the base?
Tests assertions #379
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your code passed with warnings
|
||
// THEN | ||
Assert.areEqual(1, computedCoordinates.size()); | ||
Assert.isNull(computedCoordinates[0].lat); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing Best Practice: Uncommented assertion
Severity
Warning
Finding
This assertion does not include any comments. Please add a comment that describes rationale of the assertion.
Why is this a problem?
Assertions let you test the behaviour of your application, increasing your confidence that your logic works as expected. Adding precise assertions to your tests is one of the most effective ways to detect and correct bugs. Using comments to describe the rationale of each assertion has the added benefit of documenting the inner working of the application logic, enhancing maintainability.
Help and documentation
); | ||
|
||
// THEN | ||
Assert.areEqual(1, computedCoordinates.size()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing Best Practice: Uncommented assertion
Severity
Warning
Finding
This assertion does not include any comments. Please add a comment that describes rationale of the assertion.
Why is this a problem?
Assertions let you test the behaviour of your application, increasing your confidence that your logic works as expected. Adding precise assertions to your tests is one of the most effective ways to detect and correct bugs. Using comments to describe the rationale of each assertion has the added benefit of documenting the inner working of the application logic, enhancing maintainability.
Help and documentation
// THEN | ||
Assert.areEqual(1, computedCoordinates.size()); | ||
Assert.isNull(computedCoordinates[0].lat); | ||
Assert.isNull(computedCoordinates[0].lon); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing Best Practice: Uncommented assertion
Severity
Warning
Finding
This assertion does not include any comments. Please add a comment that describes rationale of the assertion.
Why is this a problem?
Assertions let you test the behaviour of your application, increasing your confidence that your logic works as expected. Adding precise assertions to your tests is one of the most effective ways to detect and correct bugs. Using comments to describe the rationale of each assertion has the added benefit of documenting the inner working of the application logic, enhancing maintainability.
Help and documentation
|
||
// THEN | ||
Assert.areEqual(1, computedCoordinates.size()); | ||
Assert.areEqual(LATITUDE, computedCoordinates[0].lat); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing Best Practice: Uncommented assertion
Severity
Warning
Finding
This assertion does not include any comments. Please add a comment that describes rationale of the assertion.
Why is this a problem?
Assertions let you test the behaviour of your application, increasing your confidence that your logic works as expected. Adding precise assertions to your tests is one of the most effective ways to detect and correct bugs. Using comments to describe the rationale of each assertion has the added benefit of documenting the inner working of the application logic, enhancing maintainability.
Help and documentation
// THEN | ||
Assert.areEqual(1, computedCoordinates.size()); | ||
Assert.areEqual(LATITUDE, computedCoordinates[0].lat); | ||
Assert.areEqual(LONGITUDE, computedCoordinates[0].lon); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing Best Practice: Uncommented assertion
Severity
Warning
Finding
This assertion does not include any comments. Please add a comment that describes rationale of the assertion.
Why is this a problem?
Assertions let you test the behaviour of your application, increasing your confidence that your logic works as expected. Adding precise assertions to your tests is one of the most effective ways to detect and correct bugs. Using comments to describe the rationale of each assertion has the added benefit of documenting the inner working of the application logic, enhancing maintainability.
Help and documentation
); | ||
|
||
// THEN | ||
Assert.areEqual(1, computedCoordinates.size()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing Best Practice: Uncommented assertion
Severity
Warning
Finding
This assertion does not include any comments. Please add a comment that describes rationale of the assertion.
Why is this a problem?
Assertions let you test the behaviour of your application, increasing your confidence that your logic works as expected. Adding precise assertions to your tests is one of the most effective ways to detect and correct bugs. Using comments to describe the rationale of each assertion has the added benefit of documenting the inner working of the application logic, enhancing maintainability.
Help and documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congrats, your code passed without warnings 🚀
This code review is obsolete
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congrats, your code passed without warnings 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congrats, your code passed without warnings 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congrats, your code passed without warnings 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congrats, your code passed without warnings 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congrats, your code passed without warnings 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No description provided.