-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test FixBot #381
base: master
Are you sure you want to change the base?
Test FixBot #381
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review not passed
This change adds 1 new problems. See the full report
@@ -1,5 +1,5 @@ | |||
//This class is calculating the grade for every candidate neW | |||
public without sharing class CandidateGradeController2 { | |||
public class CandidateGradeController2 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Security (Orgs): Missing or incorrect sharing clause
Severity
Error
Finding
Class CandidateGradeController2
does not enforce sharing correctly. Please change to Inherited Sharing
.
Why is this a problem?
Because Apex generally runs in system context, permissions, field-level security, and sharing rules aren't taken into account during code execution. This might put applications at risk of inadvertently exposing sensitive data.
Help and documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review not passed
This change adds 1 new problems. See the full report
@@ -1,5 +1,5 @@ | |||
//This class is calculating the grade for every candidate neW | |||
public without sharing class CandidateGradeController2 { | |||
public class CandidateGradeController2 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Security (Orgs): Missing or incorrect sharing clause
Severity
Error
Finding
Class CandidateGradeController2
does not enforce sharing correctly. Please change to Inherited Sharing
.
Why is this a problem?
Because Apex generally runs in system context, permissions, field-level security, and sharing rules aren't taken into account during code execution. This might put applications at risk of inadvertently exposing sensitive data.
Help and documentation
This code review is obsolete
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review not passed
This change adds 1 new problems. See the full report
@@ -1,5 +1,5 @@ | |||
//This class is calculating the grade for every candidate neW | |||
public without sharing class CandidateGradeController2 { | |||
public class CandidateGradeController2 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Security (Orgs): Missing or incorrect sharing clause
Severity
Error
Finding
Class CandidateGradeController2
does not enforce sharing correctly. Please change to Inherited Sharing
.
Why is this a problem?
Because Apex generally runs in system context, permissions, field-level security, and sharing rules aren't taken into account during code execution. This might put applications at risk of inadvertently exposing sensitive data.
Help and documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review not passed
This is the summary of issues introduced by this change:
Policy name | Issues |
---|---|
Testing Best Practice | 0 |
Test Custom Policy Conga | 0 |
Documentation | 0 |
Large Data Volumes | 0 |
Salesforce Release Readiness | 0 |
Naming Conventions | 0 |
Security (Orgs) | 1 |
Clean Code | 0 |
Unused Code | 0 |
@@ -1,5 +1,5 @@ | |||
//This class is calculating the grade for every candidate neW | |||
public without sharing class CandidateGradeController2 { | |||
public class CandidateGradeController2 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Security (Orgs): Missing or incorrect sharing clause
Severity
Error
Finding
Class CandidateGradeController2
does not enforce sharing correctly. Please change to Inherited Sharing
.
Why is this a problem?
Because Apex generally runs in system context, permissions, field-level security, and sharing rules aren't taken into account during code execution. This might put applications at risk of inadvertently exposing sensitive data.
No description provided.