Recursion #383
Recursion #383
Conversation
![clayton-staging[bot]](https://avatars.githubusercontent.com/in/69789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code review not passed
This change adds 3 new problems. See the full report
| @@ -2,6 +2,30 @@ public class CandidateGradeController { | |||
| public CandidateGradeController() { | |||
| } | |||
|
|
|||
| //Below method is a recursive method and should cause a warning. | |||
| public static customer_Obj__c solveQueueRic(List<customer_Obj__c> COset,Integer index,customer_Obj__c head){ | |||
There was a problem hiding this comment.
Testing Best Practice: Untested method
Severity
Warning
Finding
Method solveQueueRic is not tested. Please consider adding a test method to ensure it works as expected.
Why is this a problem?
Unit tests ensure that all code meets quality standards before it's deployed. Testing all your code is essential not only to meet Salesforce test coverage requirements but, more importantly, to make sure your logic keeps working as expected as your application evolves.
Help and documentation
| if(index == 0){ | ||
| lg = COset[index]; | ||
| head = lg; | ||
| return solveQueueRic(COset,index+1,head);//This is recursive call and clayton should flag it as warning. |
There was a problem hiding this comment.
Test Custom Policy Conga: Recursion method
Severity
Critical
Finding
Recursion method
Why is this a problem?
Recursion method
| return head; | ||
| } | ||
|
|
||
| public static customer_Obj__c solveQueueRic(Integer index,customer_Obj__c head){ |
There was a problem hiding this comment.
Testing Best Practice: Untested method
Severity
Warning
Finding
Method solveQueueRic is not tested. Please consider adding a test method to ensure it works as expected.
Why is this a problem?
Unit tests ensure that all code meets quality standards before it's deployed. Testing all your code is essential not only to meet Salesforce test coverage requirements but, more importantly, to make sure your logic keeps working as expected as your application evolves.
Help and documentation
No description provided.