testing limit 20 #385
testing limit 20 #385
Conversation
![clayton-staging[bot]](https://avatars.githubusercontent.com/in/69789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code review not passed
This change adds 5 new problems. See the full report
| } | ||
|
|
||
| for (int i = 0; i < 5; i++) { | ||
| Contact currentContactl3 = [SELECT Name, Salary__c, NextAvailableDate__c FROM Contact where Id = :contactId]; |
There was a problem hiding this comment.
Large Data Volumes: Data access in loop
Severity
Error
Finding
This data query is inside a loop. Please move the query outside the loop and put records in collections for processing.
Why is this a problem?
Salesforce enforce a limit on the number of SOSL and DML statements per transaction. Reading or writing data inside loops is highly likely to hit such limits.
Help and documentation
| } | ||
|
|
||
| for (int i = 0; i < 5; i++) { | ||
| Contact currentContact = [SELECT Name, Salary__c, NextAvailableDate__c FROM Contact where Id = :contactId]; |
There was a problem hiding this comment.
Large Data Volumes: Data access in loop
Severity
Error
Finding
This data query is inside a loop. Please move the query outside the loop and put records in collections for processing.
Why is this a problem?
Salesforce enforce a limit on the number of SOSL and DML statements per transaction. Reading or writing data inside loops is highly likely to hit such limits.
Help and documentation
| } | ||
|
|
||
| for (int i = 0; i < 6; i++) { | ||
| Contact currentContactloop2 = [SELECT Name, Salary__c, NextAvailableDate__c FROM Contact where Id = :contactId]; |
There was a problem hiding this comment.
Large Data Volumes: Data access in loop
Severity
Error
Finding
This data query is inside a loop. Please move the query outside the loop and put records in collections for processing.
Why is this a problem?
Salesforce enforce a limit on the number of SOSL and DML statements per transaction. Reading or writing data inside loops is highly likely to hit such limits.
Help and documentation
| // comment 22222 gianc | ||
| @AuraEnabled | ||
| public static CandidateGradeInfo getCandidateGrade(Id contactId) { | ||
|
|
||
| for (int i = 0; i < 5; i++) { | ||
| Contact currentContactloo = [SELECT Name, Salary__c, NextAvailableDate__c FROM Contact where Id = :contactId]; |
There was a problem hiding this comment.
Large Data Volumes: Data access in loop
Severity
Error
Finding
This data query is inside a loop. Please move the query outside the loop and put records in collections for processing.
Why is this a problem?
Salesforce enforce a limit on the number of SOSL and DML statements per transaction. Reading or writing data inside loops is highly likely to hit such limits.
Help and documentation
| } | ||
|
|
||
| for (int i = 0; i < 5; i++) { | ||
| Contact currentContact = [SELECT Name, Salary__c, NextAvailableDate__c FROM Contact where Id = :contactId]; |
There was a problem hiding this comment.
Large Data Volumes: Data access in loop
Severity
Error
Finding
This data query is inside a loop. Please move the query outside the loop and put records in collections for processing.
Why is this a problem?
Salesforce enforce a limit on the number of SOSL and DML statements per transaction. Reading or writing data inside loops is highly likely to hit such limits.
Help and documentation
No description provided.