Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test inline comments3 #387

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

Mostafa-ElDahshan
Copy link
Collaborator

No description provided.

Copy link

@clayton-staging clayton-staging bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review not passed

This change adds 51 new problems. See the full report

Contact currentContactloo = [SELECT Name, Salary__c, NextAvailableDate__c FROM Contact where Id = :contactId];
}
for (int i = 0; i < 5; i++) {
Contact currentContactloo = [SELECT Name, Salary__c, NextAvailableDate__c FROM Contact where Id = :contactId];

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Large Data Volumes: Data access in loop

Severity

Error

Finding

This data query is inside a loop. Please move the query outside the loop and put records in collections for processing.

Why is this a problem?

Salesforce enforce a limit on the number of SOSL and DML statements per transaction. Reading or writing data inside loops is highly likely to hit such limits.

Help and documentation

}

for (int i = 0; i < 5; i++) {
Contact currentContactloo = [SELECT Name, Salary__c, NextAvailableDate__c FROM Contact where Id = :contactId];

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Large Data Volumes: Data access in loop

Severity

Error

Finding

This data query is inside a loop. Please move the query outside the loop and put records in collections for processing.

Why is this a problem?

Salesforce enforce a limit on the number of SOSL and DML statements per transaction. Reading or writing data inside loops is highly likely to hit such limits.

Help and documentation

}

for (int i = 0; i < 5; i++) {
Contact currentContactloo = [SELECT Name, Salary__c, NextAvailableDate__c FROM Contact where Id = :contactId];

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Large Data Volumes: Data access in loop

Severity

Error

Finding

This data query is inside a loop. Please move the query outside the loop and put records in collections for processing.

Why is this a problem?

Salesforce enforce a limit on the number of SOSL and DML statements per transaction. Reading or writing data inside loops is highly likely to hit such limits.

Help and documentation

}

for (int i = 0; i < 5; i++) {
Contact currentContactloo = [SELECT Name, Salary__c, NextAvailableDate__c FROM Contact where Id = :contactId];

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Large Data Volumes: Data access in loop

Severity

Error

Finding

This data query is inside a loop. Please move the query outside the loop and put records in collections for processing.

Why is this a problem?

Salesforce enforce a limit on the number of SOSL and DML statements per transaction. Reading or writing data inside loops is highly likely to hit such limits.

Help and documentation

}

for (int i = 0; i < 5; i++) {
Contact currentContactloo = [SELECT Name, Salary__c, NextAvailableDate__c FROM Contact where Id = :contactId];

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Large Data Volumes: Data access in loop

Severity

Error

Finding

This data query is inside a loop. Please move the query outside the loop and put records in collections for processing.

Why is this a problem?

Salesforce enforce a limit on the number of SOSL and DML statements per transaction. Reading or writing data inside loops is highly likely to hit such limits.

Help and documentation

@AuraEnabled
public static CandidateGradeInfo getCandidateGrade4(Id contactId) {

for (int i = 0; i < 5; i++) {
Contact currentContactloo = [SELECT Name, Salary__c, NextAvailableDate__c FROM Contact where Id = :contactId];

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Large Data Volumes: Data access in loop

Severity

Error

Finding

This data query is inside a loop. Please move the query outside the loop and put records in collections for processing.

Why is this a problem?

Salesforce enforce a limit on the number of SOSL and DML statements per transaction. Reading or writing data inside loops is highly likely to hit such limits.

Help and documentation

Contact currentContactloo = [SELECT Name, Salary__c, NextAvailableDate__c FROM Contact where Id = :contactId];
}
for (int i = 0; i < 5; i++) {
Contact currentContactloo = [SELECT Name, Salary__c, NextAvailableDate__c FROM Contact where Id = :contactId];

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Large Data Volumes: Data access in loop

Severity

Error

Finding

This data query is inside a loop. Please move the query outside the loop and put records in collections for processing.

Why is this a problem?

Salesforce enforce a limit on the number of SOSL and DML statements per transaction. Reading or writing data inside loops is highly likely to hit such limits.

Help and documentation

}

for (int i = 0; i < 5; i++) {
Contact currentContactloo = [SELECT Name, Salary__c, NextAvailableDate__c FROM Contact where Id = :contactId];

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Large Data Volumes: Data access in loop

Severity

Error

Finding

This data query is inside a loop. Please move the query outside the loop and put records in collections for processing.

Why is this a problem?

Salesforce enforce a limit on the number of SOSL and DML statements per transaction. Reading or writing data inside loops is highly likely to hit such limits.

Help and documentation

}

for (int i = 0; i < 5; i++) {
Contact currentContactloo = [SELECT Name, Salary__c, NextAvailableDate__c FROM Contact where Id = :contactId];

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Large Data Volumes: Data access in loop

Severity

Error

Finding

This data query is inside a loop. Please move the query outside the loop and put records in collections for processing.

Why is this a problem?

Salesforce enforce a limit on the number of SOSL and DML statements per transaction. Reading or writing data inside loops is highly likely to hit such limits.

Help and documentation

}

for (int i = 0; i < 5; i++) {
Contact currentContactloo = [SELECT Name, Salary__c, NextAvailableDate__c FROM Contact where Id = :contactId];

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Large Data Volumes: Data access in loop

Severity

Error

Finding

This data query is inside a loop. Please move the query outside the loop and put records in collections for processing.

Why is this a problem?

Salesforce enforce a limit on the number of SOSL and DML statements per transaction. Reading or writing data inside loops is highly likely to hit such limits.

Help and documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant