-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test inline comments5 #389
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review not passed
This change adds 41 new problems. See the full report
} | ||
|
||
for (int i = 0; i < 5; i++) { | ||
Contact currentContactloo = [SELECT Name, Salary__c, NextAvailableDate__c FROM Contact where Id = :contactId]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Large Data Volumes: Data access in loop
Severity
Error
Finding
This data query is inside a loop. Please move the query outside the loop and put records in collections for processing.
Why is this a problem?
Salesforce enforce a limit on the number of SOSL and DML statements per transaction. Reading or writing data inside loops is highly likely to hit such limits.
Help and documentation
} | ||
|
||
for (int i = 0; i < 5; i++) { | ||
Contact currentContactloo = [SELECT Name, Salary__c, NextAvailableDate__c FROM Contact where Id = :contactId]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Large Data Volumes: Data access in loop
Severity
Error
Finding
This data query is inside a loop. Please move the query outside the loop and put records in collections for processing.
Why is this a problem?
Salesforce enforce a limit on the number of SOSL and DML statements per transaction. Reading or writing data inside loops is highly likely to hit such limits.
Help and documentation
} | ||
|
||
for (int i = 0; i < 5; i++) { | ||
Contact currentContact = [SELECT Name, Salary__c, NextAvailableDate__c FROM Contact where Id = :contactId]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Large Data Volumes: Data access in loop
Severity
Error
Finding
This data query is inside a loop. Please move the query outside the loop and put records in collections for processing.
Why is this a problem?
Salesforce enforce a limit on the number of SOSL and DML statements per transaction. Reading or writing data inside loops is highly likely to hit such limits.
Help and documentation
} | ||
|
||
for (int i = 0; i < 5; i++) { | ||
Contact currentContactloo = [SELECT Name, Salary__c, NextAvailableDate__c FROM Contact where Id = :contactId]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Large Data Volumes: Data access in loop
Severity
Error
Finding
This data query is inside a loop. Please move the query outside the loop and put records in collections for processing.
Why is this a problem?
Salesforce enforce a limit on the number of SOSL and DML statements per transaction. Reading or writing data inside loops is highly likely to hit such limits.
Help and documentation
} | ||
|
||
for (int i = 0; i < 5; i++) { | ||
Contact currentContactloo = [SELECT Name, Salary__c, NextAvailableDate__c FROM Contact where Id = :contactId]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Large Data Volumes: Data access in loop
Severity
Error
Finding
This data query is inside a loop. Please move the query outside the loop and put records in collections for processing.
Why is this a problem?
Salesforce enforce a limit on the number of SOSL and DML statements per transaction. Reading or writing data inside loops is highly likely to hit such limits.
Help and documentation
} | ||
|
||
for (int i = 0; i < 5; i++) { | ||
Contact currentContactloo = [SELECT Name, Salary__c, NextAvailableDate__c FROM Contact where Id = :contactId]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Large Data Volumes: Data access in loop
Severity
Error
Finding
This data query is inside a loop. Please move the query outside the loop and put records in collections for processing.
Why is this a problem?
Salesforce enforce a limit on the number of SOSL and DML statements per transaction. Reading or writing data inside loops is highly likely to hit such limits.
Help and documentation
} | ||
|
||
for (int i = 0; i < 5; i++) { | ||
Contact currentContactloo = [SELECT Name, Salary__c, NextAvailableDate__c FROM Contact where Id = :contactId]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Large Data Volumes: Data access in loop
Severity
Error
Finding
This data query is inside a loop. Please move the query outside the loop and put records in collections for processing.
Why is this a problem?
Salesforce enforce a limit on the number of SOSL and DML statements per transaction. Reading or writing data inside loops is highly likely to hit such limits.
Help and documentation
} | ||
|
||
for (int i = 0; i < 5; i++) { | ||
Contact currentContactloo = [SELECT Name, Salary__c, NextAvailableDate__c FROM Contact where Id = :contactId]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Large Data Volumes: Data access in loop
Severity
Error
Finding
This data query is inside a loop. Please move the query outside the loop and put records in collections for processing.
Why is this a problem?
Salesforce enforce a limit on the number of SOSL and DML statements per transaction. Reading or writing data inside loops is highly likely to hit such limits.
Help and documentation
|
||
|
||
for (int i = 0; i < 5; i++) { | ||
Contact currentContactloo = [SELECT Name, Salary__c, NextAvailableDate__c FROM Contact where Id = :contactId]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Large Data Volumes: Data access in loop
Severity
Error
Finding
This data query is inside a loop. Please move the query outside the loop and put records in collections for processing.
Why is this a problem?
Salesforce enforce a limit on the number of SOSL and DML statements per transaction. Reading or writing data inside loops is highly likely to hit such limits.
Help and documentation
} | ||
|
||
for (int i = 0; i < 5; i++) { | ||
Contact currentContactloo = [SELECT Name, Salary__c, NextAvailableDate__c FROM Contact where Id = :contactId]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Large Data Volumes: Data access in loop
Severity
Error
Finding
This data query is inside a loop. Please move the query outside the loop and put records in collections for processing.
Why is this a problem?
Salesforce enforce a limit on the number of SOSL and DML statements per transaction. Reading or writing data inside loops is highly likely to hit such limits.
Help and documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review not passed
This is the summary of issues introduced by this change:
Policy name | Issues |
---|---|
Test Custom Policy Conga | 0 |
Documentation | 0 |
Naming Conventions | 0 |
Error Handling | 0 |
Testing Best Practice | 0 |
Clean Code | 0 |
Flow Best Practices | 0 |
Security (Orgs) | 0 |
Salesforce Release Readiness | 0 |
Large Data Volumes | 41 |
Unused Code | 0 |
See the full report to learn more. |
} | ||
|
||
for (int i = 0; i < 5; i++) { | ||
Contact currentContactloo = [SELECT Name, Salary__c, NextAvailableDate__c FROM Contact where Id = :contactId]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Large Data Volumes: Data access in loop
Severity
Error
Finding
This data query is inside a loop. Please move the query outside the loop and put records in collections for processing.
Why is this a problem?
Salesforce enforce a limit on the number of SOSL and DML statements per transaction. Reading or writing data inside loops is highly likely to hit such limits.
Help and documentation
} | ||
|
||
for (int i = 0; i < 5; i++) { | ||
Contact currentContactloo = [SELECT Name, Salary__c, NextAvailableDate__c FROM Contact where Id = :contactId]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Large Data Volumes: Data access in loop
Severity
Error
Finding
This data query is inside a loop. Please move the query outside the loop and put records in collections for processing.
Why is this a problem?
Salesforce enforce a limit on the number of SOSL and DML statements per transaction. Reading or writing data inside loops is highly likely to hit such limits.
Help and documentation
} | ||
|
||
for (int i = 0; i < 5; i++) { | ||
Contact currentContact = [SELECT Name, Salary__c, NextAvailableDate__c FROM Contact where Id = :contactId]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Large Data Volumes: Data access in loop
Severity
Error
Finding
This data query is inside a loop. Please move the query outside the loop and put records in collections for processing.
Why is this a problem?
Salesforce enforce a limit on the number of SOSL and DML statements per transaction. Reading or writing data inside loops is highly likely to hit such limits.
Help and documentation
} | ||
|
||
for (int i = 0; i < 5; i++) { | ||
Contact currentContactloo = [SELECT Name, Salary__c, NextAvailableDate__c FROM Contact where Id = :contactId]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Large Data Volumes: Data access in loop
Severity
Error
Finding
This data query is inside a loop. Please move the query outside the loop and put records in collections for processing.
Why is this a problem?
Salesforce enforce a limit on the number of SOSL and DML statements per transaction. Reading or writing data inside loops is highly likely to hit such limits.
Help and documentation
} | ||
|
||
for (int i = 0; i < 5; i++) { | ||
Contact currentContactloo = [SELECT Name, Salary__c, NextAvailableDate__c FROM Contact where Id = :contactId]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Large Data Volumes: Data access in loop
Severity
Error
Finding
This data query is inside a loop. Please move the query outside the loop and put records in collections for processing.
Why is this a problem?
Salesforce enforce a limit on the number of SOSL and DML statements per transaction. Reading or writing data inside loops is highly likely to hit such limits.
Help and documentation
} | ||
|
||
for (int i = 0; i < 5; i++) { | ||
Contact currentContactloo = [SELECT Name, Salary__c, NextAvailableDate__c FROM Contact where Id = :contactId]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Large Data Volumes: Data access in loop
Severity
Error
Finding
This data query is inside a loop. Please move the query outside the loop and put records in collections for processing.
Why is this a problem?
Salesforce enforce a limit on the number of SOSL and DML statements per transaction. Reading or writing data inside loops is highly likely to hit such limits.
Help and documentation
} | ||
|
||
for (int i = 0; i < 5; i++) { | ||
Contact currentContactloo = [SELECT Name, Salary__c, NextAvailableDate__c FROM Contact where Id = :contactId]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Large Data Volumes: Data access in loop
Severity
Error
Finding
This data query is inside a loop. Please move the query outside the loop and put records in collections for processing.
Why is this a problem?
Salesforce enforce a limit on the number of SOSL and DML statements per transaction. Reading or writing data inside loops is highly likely to hit such limits.
Help and documentation
} | ||
|
||
for (int i = 0; i < 5; i++) { | ||
Contact currentContactloo = [SELECT Name, Salary__c, NextAvailableDate__c FROM Contact where Id = :contactId]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Large Data Volumes: Data access in loop
Severity
Error
Finding
This data query is inside a loop. Please move the query outside the loop and put records in collections for processing.
Why is this a problem?
Salesforce enforce a limit on the number of SOSL and DML statements per transaction. Reading or writing data inside loops is highly likely to hit such limits.
Help and documentation
|
||
|
||
for (int i = 0; i < 5; i++) { | ||
Contact currentContactloo = [SELECT Name, Salary__c, NextAvailableDate__c FROM Contact where Id = :contactId]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Large Data Volumes: Data access in loop
Severity
Error
Finding
This data query is inside a loop. Please move the query outside the loop and put records in collections for processing.
Why is this a problem?
Salesforce enforce a limit on the number of SOSL and DML statements per transaction. Reading or writing data inside loops is highly likely to hit such limits.
Help and documentation
} | ||
|
||
for (int i = 0; i < 5; i++) { | ||
Contact currentContactloo = [SELECT Name, Salary__c, NextAvailableDate__c FROM Contact where Id = :contactId]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Large Data Volumes: Data access in loop
Severity
Error
Finding
This data query is inside a loop. Please move the query outside the loop and put records in collections for processing.
Why is this a problem?
Salesforce enforce a limit on the number of SOSL and DML statements per transaction. Reading or writing data inside loops is highly likely to hit such limits.
No description provided.