Test inline comments5 #389
Conversation
![clayton-staging[bot]](https://avatars.githubusercontent.com/in/69789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code review not passed
This change adds 41 new problems. See the full report
| } | ||
|
|
||
| for (int i = 0; i < 5; i++) { | ||
| Contact currentContactloo = [SELECT Name, Salary__c, NextAvailableDate__c FROM Contact where Id = :contactId]; |
There was a problem hiding this comment.
Large Data Volumes: Data access in loop
Severity
Error
Finding
This data query is inside a loop. Please move the query outside the loop and put records in collections for processing.
Why is this a problem?
Salesforce enforce a limit on the number of SOSL and DML statements per transaction. Reading or writing data inside loops is highly likely to hit such limits.
Help and documentation
| } | ||
|
|
||
| for (int i = 0; i < 5; i++) { | ||
| Contact currentContactloo = [SELECT Name, Salary__c, NextAvailableDate__c FROM Contact where Id = :contactId]; |
There was a problem hiding this comment.
Large Data Volumes: Data access in loop
Severity
Error
Finding
This data query is inside a loop. Please move the query outside the loop and put records in collections for processing.
Why is this a problem?
Salesforce enforce a limit on the number of SOSL and DML statements per transaction. Reading or writing data inside loops is highly likely to hit such limits.
Help and documentation
| } | ||
|
|
||
| for (int i = 0; i < 5; i++) { | ||
| Contact currentContact = [SELECT Name, Salary__c, NextAvailableDate__c FROM Contact where Id = :contactId]; |
There was a problem hiding this comment.
Large Data Volumes: Data access in loop
Severity
Error
Finding
This data query is inside a loop. Please move the query outside the loop and put records in collections for processing.
Why is this a problem?
Salesforce enforce a limit on the number of SOSL and DML statements per transaction. Reading or writing data inside loops is highly likely to hit such limits.
Help and documentation
| } | ||
|
|
||
| for (int i = 0; i < 5; i++) { | ||
| Contact currentContactloo = [SELECT Name, Salary__c, NextAvailableDate__c FROM Contact where Id = :contactId]; |
There was a problem hiding this comment.
Large Data Volumes: Data access in loop
Severity
Error
Finding
This data query is inside a loop. Please move the query outside the loop and put records in collections for processing.
Why is this a problem?
Salesforce enforce a limit on the number of SOSL and DML statements per transaction. Reading or writing data inside loops is highly likely to hit such limits.
Help and documentation
| } | ||
|
|
||
| for (int i = 0; i < 5; i++) { | ||
| Contact currentContactloo = [SELECT Name, Salary__c, NextAvailableDate__c FROM Contact where Id = :contactId]; |
There was a problem hiding this comment.
Large Data Volumes: Data access in loop
Severity
Error
Finding
This data query is inside a loop. Please move the query outside the loop and put records in collections for processing.
Why is this a problem?
Salesforce enforce a limit on the number of SOSL and DML statements per transaction. Reading or writing data inside loops is highly likely to hit such limits.
Help and documentation
| } | ||
|
|
||
| for (int i = 0; i < 5; i++) { | ||
| Contact currentContactloo = [SELECT Name, Salary__c, NextAvailableDate__c FROM Contact where Id = :contactId]; |
There was a problem hiding this comment.
Large Data Volumes: Data access in loop
Severity
Error
Finding
This data query is inside a loop. Please move the query outside the loop and put records in collections for processing.
Why is this a problem?
Salesforce enforce a limit on the number of SOSL and DML statements per transaction. Reading or writing data inside loops is highly likely to hit such limits.
Help and documentation
| } | ||
|
|
||
| for (int i = 0; i < 5; i++) { | ||
| Contact currentContactloo = [SELECT Name, Salary__c, NextAvailableDate__c FROM Contact where Id = :contactId]; |
There was a problem hiding this comment.
Large Data Volumes: Data access in loop
Severity
Error
Finding
This data query is inside a loop. Please move the query outside the loop and put records in collections for processing.
Why is this a problem?
Salesforce enforce a limit on the number of SOSL and DML statements per transaction. Reading or writing data inside loops is highly likely to hit such limits.
Help and documentation
| } | ||
|
|
||
| for (int i = 0; i < 5; i++) { | ||
| Contact currentContactloo = [SELECT Name, Salary__c, NextAvailableDate__c FROM Contact where Id = :contactId]; |
There was a problem hiding this comment.
Large Data Volumes: Data access in loop
Severity
Error
Finding
This data query is inside a loop. Please move the query outside the loop and put records in collections for processing.
Why is this a problem?
Salesforce enforce a limit on the number of SOSL and DML statements per transaction. Reading or writing data inside loops is highly likely to hit such limits.
Help and documentation
|
|
||
|
|
||
| for (int i = 0; i < 5; i++) { | ||
| Contact currentContactloo = [SELECT Name, Salary__c, NextAvailableDate__c FROM Contact where Id = :contactId]; |
There was a problem hiding this comment.
Large Data Volumes: Data access in loop
Severity
Error
Finding
This data query is inside a loop. Please move the query outside the loop and put records in collections for processing.
Why is this a problem?
Salesforce enforce a limit on the number of SOSL and DML statements per transaction. Reading or writing data inside loops is highly likely to hit such limits.
Help and documentation
| } | ||
|
|
||
| for (int i = 0; i < 5; i++) { | ||
| Contact currentContactloo = [SELECT Name, Salary__c, NextAvailableDate__c FROM Contact where Id = :contactId]; |
There was a problem hiding this comment.
Large Data Volumes: Data access in loop
Severity
Error
Finding
This data query is inside a loop. Please move the query outside the loop and put records in collections for processing.
Why is this a problem?
Salesforce enforce a limit on the number of SOSL and DML statements per transaction. Reading or writing data inside loops is highly likely to hit such limits.
Help and documentation
There was a problem hiding this comment.
Code review not passed
This is the summary of issues introduced by this change:
| Policy name | Issues |
|---|---|
| Test Custom Policy Conga | 0 |
| Documentation | 0 |
| Naming Conventions | 0 |
| Error Handling | 0 |
| Testing Best Practice | 0 |
| Clean Code | 0 |
| Flow Best Practices | 0 |
| Security (Orgs) | 0 |
| Salesforce Release Readiness | 0 |
| Large Data Volumes | 41 |
| Unused Code | 0 |
| See the full report to learn more. |
| } | ||
|
|
||
| for (int i = 0; i < 5; i++) { | ||
| Contact currentContactloo = [SELECT Name, Salary__c, NextAvailableDate__c FROM Contact where Id = :contactId]; |
There was a problem hiding this comment.
Large Data Volumes: Data access in loop
Severity
Error
Finding
This data query is inside a loop. Please move the query outside the loop and put records in collections for processing.
Why is this a problem?
Salesforce enforce a limit on the number of SOSL and DML statements per transaction. Reading or writing data inside loops is highly likely to hit such limits.
Help and documentation
| } | ||
|
|
||
| for (int i = 0; i < 5; i++) { | ||
| Contact currentContactloo = [SELECT Name, Salary__c, NextAvailableDate__c FROM Contact where Id = :contactId]; |
There was a problem hiding this comment.
Large Data Volumes: Data access in loop
Severity
Error
Finding
This data query is inside a loop. Please move the query outside the loop and put records in collections for processing.
Why is this a problem?
Salesforce enforce a limit on the number of SOSL and DML statements per transaction. Reading or writing data inside loops is highly likely to hit such limits.
Help and documentation
| } | ||
|
|
||
| for (int i = 0; i < 5; i++) { | ||
| Contact currentContact = [SELECT Name, Salary__c, NextAvailableDate__c FROM Contact where Id = :contactId]; |
There was a problem hiding this comment.
Large Data Volumes: Data access in loop
Severity
Error
Finding
This data query is inside a loop. Please move the query outside the loop and put records in collections for processing.
Why is this a problem?
Salesforce enforce a limit on the number of SOSL and DML statements per transaction. Reading or writing data inside loops is highly likely to hit such limits.
Help and documentation
| } | ||
|
|
||
| for (int i = 0; i < 5; i++) { | ||
| Contact currentContactloo = [SELECT Name, Salary__c, NextAvailableDate__c FROM Contact where Id = :contactId]; |
There was a problem hiding this comment.
Large Data Volumes: Data access in loop
Severity
Error
Finding
This data query is inside a loop. Please move the query outside the loop and put records in collections for processing.
Why is this a problem?
Salesforce enforce a limit on the number of SOSL and DML statements per transaction. Reading or writing data inside loops is highly likely to hit such limits.
Help and documentation
| } | ||
|
|
||
| for (int i = 0; i < 5; i++) { | ||
| Contact currentContactloo = [SELECT Name, Salary__c, NextAvailableDate__c FROM Contact where Id = :contactId]; |
There was a problem hiding this comment.
Large Data Volumes: Data access in loop
Severity
Error
Finding
This data query is inside a loop. Please move the query outside the loop and put records in collections for processing.
Why is this a problem?
Salesforce enforce a limit on the number of SOSL and DML statements per transaction. Reading or writing data inside loops is highly likely to hit such limits.
Help and documentation
| } | ||
|
|
||
| for (int i = 0; i < 5; i++) { | ||
| Contact currentContactloo = [SELECT Name, Salary__c, NextAvailableDate__c FROM Contact where Id = :contactId]; |
There was a problem hiding this comment.
Large Data Volumes: Data access in loop
Severity
Error
Finding
This data query is inside a loop. Please move the query outside the loop and put records in collections for processing.
Why is this a problem?
Salesforce enforce a limit on the number of SOSL and DML statements per transaction. Reading or writing data inside loops is highly likely to hit such limits.
Help and documentation
| } | ||
|
|
||
| for (int i = 0; i < 5; i++) { | ||
| Contact currentContactloo = [SELECT Name, Salary__c, NextAvailableDate__c FROM Contact where Id = :contactId]; |
There was a problem hiding this comment.
Large Data Volumes: Data access in loop
Severity
Error
Finding
This data query is inside a loop. Please move the query outside the loop and put records in collections for processing.
Why is this a problem?
Salesforce enforce a limit on the number of SOSL and DML statements per transaction. Reading or writing data inside loops is highly likely to hit such limits.
Help and documentation
| } | ||
|
|
||
| for (int i = 0; i < 5; i++) { | ||
| Contact currentContactloo = [SELECT Name, Salary__c, NextAvailableDate__c FROM Contact where Id = :contactId]; |
There was a problem hiding this comment.
Large Data Volumes: Data access in loop
Severity
Error
Finding
This data query is inside a loop. Please move the query outside the loop and put records in collections for processing.
Why is this a problem?
Salesforce enforce a limit on the number of SOSL and DML statements per transaction. Reading or writing data inside loops is highly likely to hit such limits.
Help and documentation
|
|
||
|
|
||
| for (int i = 0; i < 5; i++) { | ||
| Contact currentContactloo = [SELECT Name, Salary__c, NextAvailableDate__c FROM Contact where Id = :contactId]; |
There was a problem hiding this comment.
Large Data Volumes: Data access in loop
Severity
Error
Finding
This data query is inside a loop. Please move the query outside the loop and put records in collections for processing.
Why is this a problem?
Salesforce enforce a limit on the number of SOSL and DML statements per transaction. Reading or writing data inside loops is highly likely to hit such limits.
Help and documentation
| } | ||
|
|
||
| for (int i = 0; i < 5; i++) { | ||
| Contact currentContactloo = [SELECT Name, Salary__c, NextAvailableDate__c FROM Contact where Id = :contactId]; |
There was a problem hiding this comment.
Large Data Volumes: Data access in loop
Severity
Error
Finding
This data query is inside a loop. Please move the query outside the loop and put records in collections for processing.
Why is this a problem?
Salesforce enforce a limit on the number of SOSL and DML statements per transaction. Reading or writing data inside loops is highly likely to hit such limits.
Help and documentation
No description provided.