Testfrules2 #393
Testfrules2 #393
Conversation
![clayton-staging[bot]](https://avatars.githubusercontent.com/in/69789?s=60&v=4){kind=small}
| new TestDML2().insert1(name); | ||
| } | ||
|
|
||
| public void insert2_other(String name, ITestDML other) { |
There was a problem hiding this comment.
Intentional: Breach of naming conventions
Severity
Warning
Finding
Method insert2_other does not match naming conventions. Consider renaming (hint: myMethod).
Why is this a problem?
Naming conventions help drive consistency across the application, which makes source code easier to read and understand.
Help and documentation
| } | ||
| } | ||
|
|
||
| public static void insertsInWhileLoops() { |
There was a problem hiding this comment.
Intentional: Undocumented Apex method
Severity
Warning
Finding
This method doesn’t include any documentation or explanatory comments.
Why is this a problem?
Documenting code through comments can quickly help others understand the functionality of different classes and methods.
Help and documentation
| new TestDML2().insert1(name); | ||
| } | ||
|
|
||
| public void insert2_other(String name, ITestDML other) { |
There was a problem hiding this comment.
Resilient: Untested method
Severity
Error
Finding
Method insert2_other is not tested. Please consider adding a test method to ensure it works as expected.
Why is this a problem?
Unit tests ensure that all code meets quality standards before it's deployed. Testing all your code is essential not only to meet Salesforce test coverage requirements but, more importantly, to make sure your logic keeps working as expected as your application evolves.
Help and documentation
| } | ||
| } | ||
|
|
||
| private class TestDML2 implements ITestDML { |
There was a problem hiding this comment.
Intentional: Breach of naming conventions
Severity
Warning
Finding
Class TestDML2 does not match naming conventions. Consider renaming (hint: MyApexClass).
Why is this a problem?
Naming conventions help drive consistency across the application, which makes source code easier to read and understand.
Help and documentation
| parentInsert1(name); | ||
| } | ||
|
|
||
| public void insert2_other(String name) { |
There was a problem hiding this comment.
Intentional: Breach of naming conventions
Severity
Warning
Finding
Method insert2_other does not match naming conventions. Consider renaming (hint: myMethod).
Why is this a problem?
Naming conventions help drive consistency across the application, which makes source code easier to read and understand.
Help and documentation
| insert1(name); | ||
| } | ||
|
|
||
| public void insert2_other(String name) { |
There was a problem hiding this comment.
Intentional: Undocumented Apex method
Severity
Warning
Finding
This method doesn’t include any documentation or explanatory comments.
Why is this a problem?
Documenting code through comments can quickly help others understand the functionality of different classes and methods.
Help and documentation
| } | ||
| } | ||
|
|
||
| public static void insertsInDoWhileLoops() { |
There was a problem hiding this comment.
Engaging: Excessively complex method
Severity
Warning
Finding
Method insertsInDoWhileLoops has a cyclomatic complexity of 12.
Why is this a problem?
Complex methods are hard to test and maintain, as they have numerous paths that need to be covered. Keeping cyclomatic complexity low makes testing substantially easier.
| @@ -0,0 +1,324 @@ | |||
| public class DMLsInLoops { | |||
| public static void insertsInForLoops() { | |||
There was a problem hiding this comment.
Intentional: Undocumented Apex method
Severity
Warning
Finding
This method doesn’t include any documentation or explanatory comments.
Why is this a problem?
Documenting code through comments can quickly help others understand the functionality of different classes and methods.
Help and documentation
| } | ||
|
|
||
| private class TestDML implements ITestDML { | ||
| public void insert1(String name) { |
There was a problem hiding this comment.
Intentional: Breach of naming conventions
Severity
Warning
Finding
Method insert1 does not match naming conventions. Consider renaming (hint: myMethod).
Why is this a problem?
Naming conventions help drive consistency across the application, which makes source code easier to read and understand.
Help and documentation
| parentInsert1(name); | ||
| } | ||
|
|
||
| public void insert2_other(String name) { |
There was a problem hiding this comment.
Resilient: Untested method
Severity
Error
Finding
Method insert2_other is not tested. Please consider adding a test method to ensure it works as expected.
Why is this a problem?
Unit tests ensure that all code meets quality standards before it's deployed. Testing all your code is essential not only to meet Salesforce test coverage requirements but, more importantly, to make sure your logic keeps working as expected as your application evolves.
Help and documentation
No description provided.