fix: take border size_delta into account when calculating position #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixing the tests.... |
folke
force-pushed
the
positoning
branch
2 times, most recently
from
750c547 to
454e6fc
Compare
|
Tests pass :) |
Codecov Report
@@ Coverage Diff @@
## main #204 +/- ##
=======================================
Coverage 98.02% 98.03%
=======================================
Files 19 19
Lines 2281 2286 +5
=======================================
+ Hits 2236 2241 +5
Misses 45 45
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
position=50%, for example, will correctly position the popup, but not the border (that contains the popup).The border win position needs to be offset with half of the
size_delta.