Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(layout): handle if child.grow results in height <= 0 #375

Merged
merged 1 commit into from
Jun 26, 2024
Merged

fix(layout): handle if child.grow results in height <= 0 #375

merged 1 commit into from
Jun 26, 2024

Conversation

MunifTanjim
Copy link
Owner

resolve #371

@MunifTanjim MunifTanjim marked this pull request as ready for review June 23, 2024 04:55
@MunifTanjim
Copy link
Owner Author

@SuperBo can you check if this fixes the issue?

@SuperBo
Copy link

SuperBo commented Jun 26, 2024

@MunifTanjim, based on testing results from my machine, this branch already fixed #371. Thank you

@MunifTanjim MunifTanjim merged commit 61574ce into main Jun 26, 2024
4 checks passed
@MunifTanjim MunifTanjim deleted the resolve-371 branch June 26, 2024 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Error message when mounting layout with height = "60%" and terminal zoomed in
2 participants
@MunifTanjim @SuperBo