resultの結果をuseEffectからuseContextに移行 #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 9f46301): https://todo-real-c28fa--pr163-feat-142-result-usec-dx96vlz2.web.app (expires Thu, 23 Jan 2025 16:11:33 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: cbf065b4d5e2f44e47cd594ff42f749fc108f410 |
MurakawaTakuya
force-pushed
the
feat/142-result-useContext
branch
from
dfb56bb to
ef20dd6
Compare
MurakawaTakuya
force-pushed
the
feat/142-result-useContext
branch
4 times, most recently
from
c0334fa to
6753726
Compare
|
TODO
|
MurakawaTakuya
force-pushed
the
feat/142-result-useContext
branch
from
c3d18da to
e2015b5
Compare
MurakawaTakuya
force-pushed
the
feat/142-result-useContext
branch
from
49a02aa to
d670289
Compare
MurakawaTakuya
force-pushed
the
feat/142-result-useContext
branch
from
d670289 to
7023009
Compare
MurakawaTakuya
force-pushed
the
feat/142-result-useContext
branch
from
9637b8d to
1af7a18
Compare
MurakawaTakuya
commented
Jan 16, 2025
Comment on lines
+72
to
+75
| // keyGenerator: (req) => { | ||
| // const key = req.headers["x-forwarded-for"] || req.ip || "unknown"; | ||
| // return Array.isArray(key) ? key[0] : key; | ||
| // }, |
There was a problem hiding this comment.
これの影響で全員limitが共通になっていたので一旦解除
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes 目標作成時・削除時に更新が入らない
Closes resultのlimitとoffsetがずれてる
概要
resultの値をuseContextで保存するように変更
変更内容
useCotextを使用することでfetch回数を減らし、ロード時間の削減もできる
また、目標を作成・変更・削除した時にリロードなくても表示を更新することができる
useContextでデータの保存方法が変わったことで他の人の目標も見れるようになった
確認方法
チェックリスト