Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loggerにリクエストの詳細を記録 #169

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

MurakawaTakuya
Copy link
Owner

@MurakawaTakuya MurakawaTakuya commented Jan 19, 2025

Closes loggerにリクエストの詳細を記録

概要

Cloud Loggingにリクエストのデータやreqデータを記録
参考

変更内容

  • httpデータ
    {
        requestMethod: req.method,
        requestUrl: `${req.method} ${statusCode}: ${req.protocol}://${req.get(
          "host"
        )}${req.originalUrl}`,
        status: statusCode,
        userAgent: req.get("User-Agent"),
        remoteIp: req.ip,
        protocol: req.httpVersion ? `HTTP/${req.httpVersion}` : req.protocol,
    }
  • リクエストデータ
    {
        headers: req.headers,
        parameters: {
          query: req.query,
          params: req.params,
        },
        body: req.body,
    }

確認方法

チェックリスト

  • PRに必要な内容を記述し、Assignやタイトルを設定した
  • File Changedで不要な変更や誤った変更が無いか確認した
  • 対応したissueをProjectの"レビュー中・待機中"に移動した
  • レビューを頼んだ人にDiscordでお願いした
  • 機密情報が含まれていないことを確認した(含まれている場合は直ちにリモートからコミットを削除すること)
  • UIを変更した場合
    • PCで見た時に表示が崩れていないことを確認した
    • スマホでも正常に表示されることを確認した(大きい画面と小さい画面両方で)

@MurakawaTakuya MurakawaTakuya self-assigned this Jan 19, 2025
Copy link

github-actions bot commented Jan 20, 2025

Visit the preview URL for this PR (updated for commit 105ddef):

https://todo-real-c28fa--pr169-feat-168-logger-head-l288289k.web.app

(expires Mon, 27 Jan 2025 07:41:13 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: cbf065b4d5e2f44e47cd594ff42f749fc108f410

@MurakawaTakuya MurakawaTakuya force-pushed the feat/168-logger-header-request branch from 3de3845 to 105ddef Compare January 20, 2025 07:39
@MurakawaTakuya MurakawaTakuya marked this pull request as ready for review January 20, 2025 07:43
@MurakawaTakuya MurakawaTakuya merged commit 7f5f575 into main Jan 20, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

loggerにリクエストの詳細を記録
1 participant