Skip to content

Commit

Permalink
fix(core): Fix VideoItem typo, closes #529
Browse files Browse the repository at this point in the history
  • Loading branch information
MurhafSousli committed Apr 23, 2023
1 parent 0abc6bd commit 5337609
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ export class GalleryItemComponent implements AfterViewChecked {
if (this.isActive && this.type === GalleryItemType.Youtube && (this.data as YoutubeItemData).autoplay) {
autoplay = 1;
}
const url = new URL(this.data.src);
const url = new URL(this.data.src as string);
url.search = new URLSearchParams({
wmode: 'transparent',
...(this.data as YoutubeItemData).params,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export class YoutubeItem implements GalleryItem {

type GalleryItemModel = {
type?: string;
src?: string;
src?: string | { url: string, type: string }[];
thumb?: string;
};

Expand All @@ -66,8 +66,6 @@ export type YoutubeItemData = IframeItemData & {
};

export type VideoItemData = GalleryItemModel & {
src?: string | { url: string, type: string }[];
thumb?: string;
poster?: string;
loop?: boolean;
// The only option for boolean video attributes is 'true', because false will still be evaluated to true in attributes binding
Expand Down

0 comments on commit 5337609

Please sign in to comment.