Add support for trusted types (CSP) #230
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there!
TLDR; This PR enables apps served with
require-trusted-types-for 'script'
CSP header to work with ngx-highlightjs.We (and probably other folks out there) need to be able to use the HTTP Content-Security-Policy (CSP) trusted-types
The gist of it is that the ngx-highlightjs uses
innerHTML
assignment (with Angular sanitizer which is correct) but still evaluated as a security risk by the CSP. Therefore we have to create a policy to allow consumers to trust the library.In consumer application then CSP can be enabled for local development and testing using
Keep in mind that in the end it is the responsibility of server to set correct CSP headers when serving the application (not responsibility of this lib).
This solution is heavily inspired by Angular own solution
Read more about trusted types and their support in Angular