Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some wrapdb fixes #137

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

some wrapdb fixes #137

wants to merge 2 commits into from

Conversation

neheb
Copy link
Contributor

@neheb neheb commented Nov 18, 2024

Related: mesonbuild/wrapdb#1345

I don't know if it's enough to fix.

@neheb
don't redefine ssize_t on MinGW
82aebb5 
headers already define it. also causes compilation issue on 32-bit.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
@MaxKellermann
Copy link
Member

I don't understand the third patch. The commit message says "use ld for function definitions even on non Linux / GCC is available on MinGW" but the diff is neither about ld nor about gcc.

@neheb
Copy link
Contributor Author

neheb commented Nov 18, 2024

The file is named .ld

@MaxKellermann
Copy link
Member

I still don't get it. And I've grown wary of merging your low-effort stuff. Too often did you submit code changes to me that even you didn't understand. I only merge anything from you with a proper commit message that explains every detail.

@neheb
Copy link
Contributor Author

neheb commented Nov 18, 2024

I'll remove it. It's not important anyway.

@MaxKellermann
Copy link
Member

"meson: add def file"
Bad commit message. I have no idea what this is about.
Oh please. I just wrote I want proper commit messages, and now you submit another commit with a bad commit message.

@neheb
meson: add def file
34d07c0 
A def file is needed on MSVC in lieu of dllexport/dllimport declarations
in the code. Should have the same symbols as libmpdclient.ld.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
@MaxKellermann
Copy link
Member

Why did you remove link_depends?
And who is going to maintain this new def file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neheb @MaxKellermann